[AOTInductor] Wrapper codegen fixes #111089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The changes: 1. When using fake inputs make sure they are on the same device as the original inputs. 1. Don't change the value of `self.cpp_wrapper` from `True` to `False` if can't generate a C++ wrapper, instead have a check and fail early to avoid producing Python code for C++ compiler. Differential Revision: D50154720
|
This pull request was exported from Phabricator. Differential Revision: D50154720 |
|
@pytorchbot label "topic: not user facing" |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 13, 2023
It's a reimplementation of #111089 1. When using fake inputs make sure they are on the same device as the original inputs. 2. Don't change the value of self.cpp_wrapper from True to False if can't generate a C++ wrapper, instead have a check and fail early to avoid producing Python code for C++ compiler. Pull Request resolved: #111102 Approved by: https://github.com/desertfire, https://github.com/jgong5, https://github.com/chunyuan-w
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
It was implemented in #111102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The changes:
self.cpp_wrapperfromTruetoFalseif can't generate a C++ wrapper, instead have a check and fail early to avoid producing Python code for C++ compiler.Differential Revision: D50154720
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler