KEMBAR78
[inductor] Allow backend compiler to skip by bertmaher · Pull Request #111153 · pytorch/pytorch · GitHub
Skip to content

[inductor] Allow backend compiler to skip #111153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[inductor] Allow backend compiler to skip #111153

wants to merge 1 commit into from

Conversation

@bertmaher
Copy link
Contributor

@bertmaher bertmaher commented Oct 12, 2023 •
edited by pytorch-bot bot
Loading

Summary:
Sometimes the backend compiler can encounter a transient failure (in
our case, a remote build service infrequently hits a hiccup). We'd rather run
eager than fail the training job.

Test Plan:
Inject an exception in the RE path and run:

buck2 run @//mode/{opt,inplace} //caffe2/test/inductor:smoke

Differential Revision: D50234516

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 12, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111153

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit e9166c4 with merge base c2ed714 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50234516

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50234516

@bertmaher @facebook-github-bot
[inductor] Allow backend compiler to skip (pytorch#111153)
e9166c4 
Summary:

Sometimes the backend compiler can encounter a transient failure (in
our case, a remote build service infrequently hits a hiccup).  We'd rather run
eager than fail the training job.

Test Plan:
Inject an exception in the RE path and run:
```
buck2 run @//mode/{opt,inplace} //caffe2/test/inductor:smoke
```

Reviewed By: jansel

Differential Revision: D50234516
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50234516

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50234516

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@jansel jansel jansel approved these changes

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

Assignees

No one assigned

Labels

ciflow/inductor fb-exported Merged module: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bertmaher @facebook-github-bot @pytorchmergebot @ezyang @jansel