KEMBAR78
Don't sympify reflection_pad2d ranges by ezyang · Pull Request #111212 · pytorch/pytorch · GitHub
Skip to content

Don't sympify reflection_pad2d ranges #111212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't sympify reflection_pad2d ranges #111212

wants to merge 1 commit into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 13, 2023 •
edited by pytorch-bot bot
Loading

@ezyang
Don't sympify reflection_pad2d ranges
f94e9b8 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111212

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f94e9b8 with merge base 8162f41 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Oct 13, 2023
@ezyang
Don't sympify reflection_pad2d ranges
388edc2 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: fe75414
Pull Request resolved: #111212
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2023
@ezyang ezyang requested a review from eellison October 13, 2023 17:37
@albanD albanD removed their request for review October 13, 2023 17:42
@ezyang
Copy link
Contributor Author

ezyang commented Oct 13, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added the topic: not user facing topic category label Oct 13, 2023
@ezyang
Copy link
Contributor Author

ezyang commented Oct 13, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2387/head branch October 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @pytorchmergebot @eellison