KEMBAR78
[HigherOrderOp] Move map_impl to torch.ops.higher_order by ydwu4 · Pull Request #111404 · pytorch/pytorch · GitHub
Skip to content

Conversation

@ydwu4
Copy link
Contributor

@ydwu4 ydwu4 commented Oct 16, 2023

The purpose of this pr is as titled. Because of some misusage of ghstack, ghimport, and export to github from internal, the stack of #111092 is a mess. I'll try to land them one by one. This is a replacement for #111092 and #111400.

cc @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111404

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8660dc4 with merge base 7e654c8 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ydwu4 ydwu4 requested a review from angelayi October 16, 2023 23:30
@ydwu4 ydwu4 added ciflow/trunk Trigger trunk jobs on your pull request release notes: export labels Oct 16, 2023
@facebook-github-bot
Copy link
Contributor

@ydwu4 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good luck

facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2023
Summary:
The purpose of this pr is as titled. Due to some misusage of ghstack, ghimport, and export to github from internal, the stack of #111092 is a mess. I'll try to land them one by one. This is a replacement for #111092 and #111400.


cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan


Reviewed By: zou3519, tugsbayasgalan

Differential Revision: D50347324

Pulled By: ydwu4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50347324

facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2023
Summary:
The purpose of this pr is as titled. Due to some misusage of ghstack, ghimport, and export to github from internal, the stack of #111092 is a mess. I'll try to land them one by one. This is a replacement for #111092 and #111400.


cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan


Reviewed By: zou3519, tugsbayasgalan

Differential Revision: D50347324

Pulled By: ydwu4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50347324

facebook-github-bot pushed a commit that referenced this pull request Oct 19, 2023
Summary:
The purpose of this pr is as titled. Due to some misusage of ghstack, ghimport, and export to github from internal, the stack of #111092 is a mess. I'll try to land them one by one. This is a replacement for #111092 and #111400.


cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan


Reviewed By: zou3519, tugsbayasgalan

Differential Revision: D50347324

Pulled By: ydwu4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50347324

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50347324

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50347324

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50347324

facebook-github-bot pushed a commit that referenced this pull request Oct 24, 2023
Summary:
The purpose of this pr is as titled. Due to some misusage of ghstack, ghimport, and export to github from internal, the stack of #111092 is a mess. I'll try to land them one by one. This is a replacement for #111092 and #111400.


cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan


Reviewed By: zou3519, tugsbayasgalan

Differential Revision: D50347324

Pulled By: ydwu4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50347324

Summary:
The purpose of this pr is as titled. Due to some misusage of ghstack, ghimport, and export to github from internal, the stack of #111092 is a mess. I'll try to land them one by one. This is a replacement for #111092 and #111400.


cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan


Reviewed By: zou3519, tugsbayasgalan

Differential Revision: D50347324

Pulled By: ydwu4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50347324

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
The purpose of this pr is as titled. Because of some misusage of ghstack, ghimport, and export to github from internal, the stack of pytorch#111092 is a mess. I'll try to land them one by one. This is a replacement for pytorch#111092 and pytorch#111400.

Pull Request resolved: pytorch#111404
Approved by: https://github.com/tugsbayasgalan, https://github.com/zou3519
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
The purpose of this pr is as titled. Because of some misusage of ghstack, ghimport, and export to github from internal, the stack of pytorch#111092 is a mess. I'll try to land them one by one. This is a replacement for pytorch#111092 and pytorch#111400.

Pull Request resolved: pytorch#111404
Approved by: https://github.com/tugsbayasgalan, https://github.com/zou3519
@github-actions github-actions bot deleted the migrate_map branch April 27, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants