KEMBAR78
new_qtensor support privateuseone allocator. by huihoaan · Pull Request #111464 · pytorch/pytorch · GitHub
Skip to content

Conversation

@huihoaan
Copy link
Contributor

I want to create a quant tensor through PerTensorAffineQuantizer. But I found that it will throw error because of the lake of judgment for PrivateUse1.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111464

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 78338f2 with merge base 93a9b13 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the release notes: quantization release notes category label Oct 18, 2023
@jbschlosser jbschlosser added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 18, 2023
@huihoaan
Copy link
Contributor Author

@supriyar Could you take a look at this pr?

@supriyar
Copy link
Contributor

can you add relevant testing to accompany this code change? cc @jerryzh168 to help review

@huihoaan
Copy link
Contributor Author

can you add relevant testing to accompany this code change? cc @jerryzh168 to help review

I've added a unittest for this case. Because quantize's calculations are complex and are registered elsewhere, I've just written an empty function for quantize_tensor_per_tensor_affine_stub.

@huihoaan
Copy link
Contributor Author

@supriyar @jerryzh168 please take a look at this pr.

@jerryzh168
Copy link
Contributor

@huihoaan what is use case for this? we are actually moving away from having native quantized tensor in pytorch core going forward

@huihoaan
Copy link
Contributor Author

@huihoaan what is use case for this? we are actually moving away from having native quantized tensor in pytorch core going forward

Our customer has a strong will to use this interface,the first step is to allow us to create a quantized tenser. So new_qtensor need to allow to get privateuse1 allocator. @jerryzh168

@jerryzh168
Copy link
Contributor

without more information about how this is going to be used I don't know how to review this, I've talked about the plan from our team on these things, I'm not sure how open we are to accept extensions to things that we plan to deprecate� from pytorch core side, cc @ezyang @albanD

@ezyang
Copy link
Contributor

ezyang commented Nov 1, 2023

when it's something innocuous like this I just accept it

@ezyang
Copy link
Contributor

ezyang commented Nov 1, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 1, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
I want to create a quant tensor through `PerTensorAffineQuantizer`. But I found that it will throw error because of the lake of judgment for PrivateUse1.
Pull Request resolved: pytorch#111464
Approved by: https://github.com/ezyang
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
I want to create a quant tensor through `PerTensorAffineQuantizer`. But I found that it will throw error because of the lake of judgment for PrivateUse1.
Pull Request resolved: pytorch#111464
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: quantization release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants