KEMBAR78
[qnnpack] suppress empty translation unit warning by h-friederich · Pull Request #111475 · pytorch/pytorch · GitHub
Skip to content

[qnnpack] suppress empty translation unit warning #111475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[qnnpack] suppress empty translation unit warning #111475

wants to merge 1 commit into from

Conversation

@h-friederich
Copy link
Contributor

@h-friederich h-friederich commented Oct 18, 2023 •
edited by pytorch-bot bot
Loading

Summary: Spotted this while compiling on a Mac M1. The code in these files is gated behind #ifdef and requires SSE, so when building for ARM these files become empty.

Test Plan: CI

Differential Revision: D50407334

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111475

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4d9bf9b with merge base 1ddbdb5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Oct 18, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: h-friederich / name: Hannes Friederich (4d9bf9b)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50407334

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Oct 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50407334

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50407334

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50407334

@h-friederich @facebook-github-bot
[qnnpack] suppress empty translation unit warning (pytorch#111475)
4d9bf9b 
Summary:

Spotted this while compiling on a Mac M1. The code in these files is gated behind #ifdef and requires SSE, so when building for ARM these files become empty.

Test Plan: CI

Reviewed By: digantdesai

Differential Revision: D50407334
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50407334

digantdesai
digantdesai approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 24, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@h-friederich @xuhancn
[qnnpack] suppress empty translation unit warning (pytorch#111475)
9042fa9 
Summary: Spotted this while compiling on a Mac M1. The code in these files is gated behind #ifdef and requires SSE, so when building for ARM these files become empty.

Test Plan: CI

Differential Revision: D50407334

Pull Request resolved: pytorch#111475
Approved by: https://github.com/digantdesai
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@h-friederich @Skylion007
[qnnpack] suppress empty translation unit warning (pytorch#111475)
75ed8ff 
Summary: Spotted this while compiling on a Mac M1. The code in these files is gated behind #ifdef and requires SSE, so when building for ARM these files become empty.

Test Plan: CI

Differential Revision: D50407334

Pull Request resolved: pytorch#111475
Approved by: https://github.com/digantdesai
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@salilsdesai salilsdesai Awaiting requested review from salilsdesai salilsdesai is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@jianyuh jianyuh Awaiting requested review from jianyuh jianyuh is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: cpu CPU specific problem (e.g., perf, algorithm) release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@h-friederich @facebook-github-bot @pytorchmergebot @digantdesai