KEMBAR78
[vmap] symintify : is_same_size and split_with_sizes by kshitij12345 · Pull Request #111491 · pytorch/pytorch · GitHub
Skip to content

[vmap] symintify : is_same_size and split_with_sizes #111491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[vmap] symintify : is_same_size and split_with_sizes #111491

wants to merge 1 commit into from

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Oct 18, 2023 •
edited by pytorch-bot bot
Loading

Partial : #111312

Reference: Point 1 of #111312 (comment)

Should this have a test?

cc @zou3519 @Chillee @samdow @janeyx99

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111491

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 20a34e8 with merge base e2f1d03 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kshitij12345 kshitij12345 requested a review from zou3519 October 18, 2023 18:15
@kshitij12345 kshitij12345 marked this pull request as ready for review October 18, 2023 18:15
@Skylion007 Skylion007 added the module: functorch Pertaining to torch.func or pytorch/functorch label Oct 18, 2023
@Skylion007
Copy link
Collaborator

I suspect you'll need to remove an xfail from somewhere, if not we might not have coverage of this function which would be unfortuante.

@zou3519
Copy link
Contributor

zou3519 commented Oct 18, 2023

Should this have a test?

Nah it's fine

@kshitij12345 kshitij12345 added the release notes: torch.func release notes category for torch.vmap or torch.func.* APIs label Oct 19, 2023
@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kshitij12345 kshitij12345 deleted the symintify-batch-rules branch October 19, 2023 11:13
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@kshitij12345 @xuhancn
[vmap] symintify : is_same_size and split_with_sizes (pytorch#111491)
fb5259f 
Partial : pytorch#111312

Reference: Point 1 of pytorch#111312 (comment)

Should this have a test?

Pull Request resolved: pytorch#111491
Approved by: https://github.com/Skylion007, https://github.com/zou3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: functorch Pertaining to torch.func or pytorch/functorch open source release notes: torch.func release notes category for torch.vmap or torch.func.* APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kshitij12345 @Skylion007 @zou3519 @pytorchmergebot @pytorchbot