[PyTorch][Vulkan] Allow 0-size tensors to be represented in PyTorch Vulkan #111512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
ciflow/periodic
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111512
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit ee668b8 with merge base 675df75 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
force-pushed
the
export-D50030659
branch
from
30d7336 to
a1e19ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50030659 |
SS-JIA
force-pushed
the
export-D50030659
branch
from
a1e19ea to
1627793
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50030659 |
SS-JIA
force-pushed
the
export-D50030659
branch
from
1627793 to
22b7ba8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50030659 |
SS-JIA
force-pushed
the
export-D50030659
branch
from
22b7ba8 to
75c3472
Compare
yipjustin
approved these changes
Oct 19, 2023
SS-JIA
force-pushed
the
export-D50030659
branch
from
75c3472 to
f79ba19
Compare
…ulkan (pytorch#111512) Summary: 0-size tensors are allowed in PyTorch (e.g. a tensor with size {2, 1, 0}). However, this currently causes issues with PyTorch Vulkan as the Vulkan API would raise an error when attempting to allocate a resource with no memory. This diff fixes the behaviour by adding support for `VulkanImage` and `VulkanBuffer` objects that do not have any associated memory. Test Plan: Tested locally with `vulkan_api_test` on Mac as a sanity test. ``` buck run //xplat/caffe2:pt_vulkan_api_test_bin --target-platforms ovr_config//platform/macos:x86_64-fbsource -- --gtest_filter="*" ``` But given how foundational of a change this is, more extensive testing should be done in order to be safe. Reviewed By: yipjustin Differential Revision: D50030659
|
This pull request was exported from Phabricator. Differential Revision: D50030659 |
SS-JIA
force-pushed
the
export-D50030659
branch
from
f79ba19 to
ee668b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50030659 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…ulkan (pytorch#111512) Summary: 0-size tensors are allowed in PyTorch (e.g. a tensor with size {2, 1, 0}). However, this currently causes issues with PyTorch Vulkan as the Vulkan API would raise an error when attempting to allocate a resource with no memory. This diff fixes the behaviour by adding support for `VulkanImage` and `VulkanBuffer` objects that do not have any associated memory. Test Plan: Tested locally with `vulkan_api_test` on Mac as a sanity test. ``` buck run //xplat/caffe2:pt_vulkan_api_test_bin --target-platforms ovr_config//platform/macos:x86_64-fbsource -- --gtest_filter="*" ``` But given how foundational of a change this is, more extensive testing should be done in order to be safe. Reviewed By: yipjustin Differential Revision: D50030659 Pull Request resolved: pytorch#111512 Approved by: https://github.com/yipjustin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
0-size tensors are allowed in PyTorch (e.g. a tensor with size {2, 1, 0}). However, this currently causes issues with PyTorch Vulkan as the Vulkan API would raise an error when attempting to allocate a resource with no memory.
This diff fixes the behaviour by adding support for
VulkanImageandVulkanBufferobjects that do not have any associated memory.Test Plan:
Tested locally with
vulkan_api_teston Mac as a sanity test.But given how foundational of a change this is, more extensive testing should be done in order to be safe.
Reviewed By: yipjustin
Differential Revision: D50030659