KEMBAR78
[pt2][quant] Clean up QAT get conv-bn-relu nodes by andrewor14 · Pull Request #111515 · pytorch/pytorch · GitHub
Skip to content

[pt2][quant] Clean up QAT get conv-bn-relu nodes #111515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[pt2][quant] Clean up QAT get conv-bn-relu nodes #111515

wants to merge 5 commits into from

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Oct 18, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

@andrewor14
[pt2][quant] Clean up QAT get conv-bn-relu nodes
55e06f1 
Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111515

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 809d771 with merge base 74f6f7a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the release notes: quantization release notes category label Oct 18, 2023
@andrewor14 andrewor14 requested a review from jerryzh168 October 18, 2023 21:43
jerryzh168
jerryzh168 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! is there plans to extend SubgraphRewriter with the recent support for SubgraphMatcherWithNodeNameMap?

@andrewor14
Update on "[pt2][quant] Clean up QAT get conv-bn-relu nodes"
cea418e 
Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

[ghstack-poisoned]
@andrewor14
Update on "[pt2][quant] Clean up QAT get conv-bn-relu nodes"
61692d9 
Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

[ghstack-poisoned]
@andrewor14
Copy link
Contributor Author

thanks! is there plans to extend SubgraphRewriter with the recent support for SubgraphMatcherWithNodeNameMap?

Yes that would simplify the changes in this PR significantly if we have that

andrewor14 added a commit that referenced this pull request Oct 18, 2023
@andrewor14
[pt2][quant] Clean up QAT get conv-bn-relu nodes
e237621 
Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: db92176
Pull Request resolved: #111515
@jerryzh168
Copy link
Contributor

thanks! is there plans to extend SubgraphRewriter with the recent support for SubgraphMatcherWithNodeNameMap?

Yes that would simplify the changes in this PR significantly if we have that

OK, maybe we can make that a BE task

@andrewor14
Update on "[pt2][quant] Clean up QAT get conv-bn-relu nodes"
2ffff57 
Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

[ghstack-poisoned]
@andrewor14
Update on "[pt2][quant] Clean up QAT get conv-bn-relu nodes"
809d771 
Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

[ghstack-poisoned]
andrewor14 added a commit that referenced this pull request Oct 19, 2023
@andrewor14
[pt2][quant] Clean up QAT get conv-bn-relu nodes
175af20 
Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 49b0ff3
Pull Request resolved: #111515
@andrewor14
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/andrewor14/34/head branch October 24, 2023 14:23
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@andrewor14 @xuhancn
[pt2][quant] Clean up QAT get conv-bn-relu nodes (pytorch#111515)
783b1e7 
Summary: Reduces duplicate code to map original matched nodes
to replacement nodes.

Test Plan:
python test/test_quantization.py TestQuantizePT2EQAT

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar
Pull Request resolved: pytorch#111515
Approved by: https://github.com/jerryzh168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: AO frontend release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewor14 @jerryzh168 @pytorchmergebot