KEMBAR78
Add CSR tensor with non-contiguous values support to CuSparseSpMatCsrDescriptor by pearu · Pull Request #111742 · pytorch/pytorch · GitHub
Skip to content

Add CSR tensor with non-contiguous values support to CuSparseSpMatCsrDescriptor #111742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add CSR tensor with non-contiguous values support to CuSparseSpMatCsrDescriptor #111742

wants to merge 1 commit into from

Conversation

pearu
Copy link
Collaborator

@pearu pearu commented Oct 21, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111742

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 14c746c with merge base 3ca81ae (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pearu added a commit that referenced this pull request Oct 21, 2023
@pearu
Add CSR tensor with non-contiguous values support to CuSparseSpMatCsr…
5dec2a9 
…Descriptor

ghstack-source-id: 61b55b8
Pull Request resolved: #111742
@pearu pearu added module: sparse Related to torch.sparse release notes: sparse release notes category topic: new features topic category open source labels Oct 21, 2023
@pearu pearu linked an issue Oct 21, 2023 that may be closed by this pull request
illegal memory access for torch.sparse.mm(src, other) / deg.view(-1, 1).clamp_(min=1) #111574
Closed
@pearu pearu requested review from amjames and cpuhrsch October 21, 2023 10:57
amjames
amjames approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@amjames amjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyyever
Copy link
Collaborator

cyyever commented Oct 21, 2023

So the debug_assertion of values was changed into a runtime exception provided by maybe owned. But how about col_indices and crow_indices? Should they be changed similarly?

@pearu
Copy link
Collaborator Author

pearu commented Oct 21, 2023

So the debug_assertion of values was changed into a runtime exception provided by maybe owned. But how about col_indices and crow_indices? Should they be changed similarly?

No: the contiguity requirements of crow_indices and col_indices are already checked when validating arguments to CSR tensor constructor:

pytorch/aten/src/ATen/native/sparse/SparseCsrTensor.cpp

Lines 187 to 193 in 39f4846

// 3.5
TORCH_CHECK(plain_indices.stride(-1) == 1,
"expected ", plain_indices_name, " to be a contiguous tensor per batch");
// 3.6
TORCH_CHECK(compressed_indices.stride(-1) == 1,
"expected ", compressed_indices_name, " to be a contiguous tensor per batch");

@cpuhrsch
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 23, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet added this to the 2.1.1 milestone Oct 24, 2023
@facebook-github-bot facebook-github-bot deleted the gh/pearu/123/head branch October 27, 2023 14:25
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@pearu @xuhancn
Add CSR tensor with non-contiguous values support to CuSparseSpMatCsr…
7c741b5 
…Descriptor (pytorch#111742)

Fixes pytorch#111574

Pull Request resolved: pytorch#111742
Approved by: https://github.com/amjames, https://github.com/cpuhrsch
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@pearu @Skylion007
Add CSR tensor with non-contiguous values support to CuSparseSpMatCsr…
fdba8ca 
…Descriptor (pytorch#111742)

Fixes pytorch#111574

Pull Request resolved: pytorch#111742
Approved by: https://github.com/amjames, https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@amjames amjames amjames approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: sparse Related to torch.sparse open source release notes: sparse release notes category topic: new features topic category

Projects

Sparse tensors
Status: Done

Milestone

2.1.1

Development

Successfully merging this pull request may close these issues.

illegal memory access for torch.sparse.mm(src, other) / deg.view(-1, 1).clamp_(min=1)

6 participants

@pearu @cyyever @cpuhrsch @pytorchmergebot @amjames @malfet