[quant][be] Clean up prepare code #111827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att Test Plan: CI Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111827
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e0c3558 with merge base d22e5e4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
requested review from
andrewor14,
kimishpatel and
leslie-fang-intel
andrewor14
approved these changes
Oct 24, 2023
Summary: att Test Plan: CI Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 25, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: #111828 Approved by: https://github.com/kimishpatel ghstack dependencies: #111827
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: att Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#111827 Approved by: https://github.com/andrewor14
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#111828 Approved by: https://github.com/kimishpatel ghstack dependencies: pytorch#111827
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Summary: att Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#111827 Approved by: https://github.com/andrewor14
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#111828 Approved by: https://github.com/kimishpatel ghstack dependencies: pytorch#111827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
att
Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags: