[MPS] Add complex support for fill
#111885
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pytorch-bot
bot
added
ciflow/mps
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111885
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e4fad99 with merge base fb88760 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
qqaatw
changed the title
fill
[ghstack-poisoned]
[ghstack-poisoned]
qqaatw
commented
Oct 24, 2023
Comment on lines
98
to
99
| fill_scalar_mps_impl(self_as_real_real, Scalar(value_cdouble.real())); | ||
| fill_scalar_mps_impl(self_as_real_imag, Scalar(value_cdouble.imag())); |
There was a problem hiding this comment.
Suggested change
| fill_scalar_mps_impl(self_as_real_real, Scalar(value_cdouble.real())); | |
| fill_scalar_mps_impl(self_as_real_imag, Scalar(value_cdouble.imag())); | |
| fill_scalar_mps_impl(self_as_real_real, value_cdouble.real()); | |
| fill_scalar_mps_impl(self_as_real_imag, value_cdouble.imag()); |
malfet
approved these changes
Oct 24, 2023
Fixes #110537 [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 31, 2023
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: #111937 Approved by: https://github.com/malfet ghstack dependencies: #111885
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Fixes pytorch#110537 Pull Request resolved: pytorch#111885 Approved by: https://github.com/malfet
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: pytorch#111937 Approved by: https://github.com/malfet ghstack dependencies: pytorch#111885
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Fixes pytorch#110537 Pull Request resolved: pytorch#111885 Approved by: https://github.com/malfet
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: pytorch#111937 Approved by: https://github.com/malfet ghstack dependencies: pytorch#111885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
fill#111885Fixes #110537