KEMBAR78
[Inductor] Support calling user defined kernels with different type of arguments by oulgen · Pull Request #111939 · pytorch/pytorch · GitHub
Skip to content

[Inductor] Support calling user defined kernels with different type of arguments #111939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Inductor] Support calling user defined kernels with different type of arguments #111939

wants to merge 1 commit into from

Conversation

@oulgen
Copy link
Contributor

@oulgen oulgen commented Oct 24, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111939

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0b73064 with merge base 2b2b6ca (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

oulgen added a commit that referenced this pull request Oct 24, 2023
@oulgen
[Inductor] Support calling user defined kernels with different type o…
a28c667 
…f arguments

ghstack-source-id: 8e8ef25
Pull Request resolved: #111939
@oulgen oulgen requested review from Chillee and jansel October 24, 2023 16:30
@oulgen oulgen added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 24, 2023
@oulgen oulgen requested a review from zou3519 October 24, 2023 16:30
oulgen
oulgen commented Oct 24, 2023
View reviewed changes
torch/_inductor/codegen/wrapper.py
self.supports_intermediate_hooks = True
self.expr_printer = pexpr
self.cached_thread_locals = set()
self.user_defined_kernel_count = 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could make this unique to each kernel name, i.e. Dict[str, int] but other than nicer function names, it doesn't really help

@oulgen
Copy link
Contributor Author

oulgen commented Oct 24, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@oulgen oulgen added the topic: not user facing topic category label Oct 24, 2023
@oulgen
Copy link
Contributor Author

oulgen commented Oct 24, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Oct 24, 2023
Closed
Closed
@facebook-github-bot facebook-github-bot deleted the gh/oulgen/13/head branch October 28, 2023 14:24
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@oulgen @xuhancn
[Inductor] Support calling user defined kernels with different type o…
a4a8817 
…f arguments (pytorch#111939)

Pull Request resolved: pytorch#111939
Approved by: https://github.com/jansel, https://github.com/zou3519
ghstack dependencies: pytorch#111770, pytorch#111808
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@oulgen @Skylion007
[Inductor] Support calling user defined kernels with different type o…
86160d5 
…f arguments (pytorch#111939)

Pull Request resolved: pytorch#111939
Approved by: https://github.com/jansel, https://github.com/zou3519
ghstack dependencies: pytorch#111770, pytorch#111808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@zou3519 zou3519 zou3519 approved these changes

@Chillee Chillee Awaiting requested review from Chillee

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oulgen @pytorchmergebot @jansel @zou3519