[torchx] Do not terminate parent process if exit code from child isn't valid #111961
Conversation
atuljangra
requested review from
H-Huang,
awgu,
d4l3k,
fduwjj,
fegin,
kiukchung,
kwen2501,
mrshenli,
rohan-varma,
wanchaol,
wz337 and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111961
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 64a9f4a with merge base ad4971c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
This pull request was exported from Phabricator. Differential Revision: D50615419 |
|
Added the correct email address as well. |
|
/easycla |
That check is passing now, once all the signals pass, we can use pytorchbot to merge this PR. |
|
This pull request was exported from Phabricator. Differential Revision: D50615419 |
atuljangra
force-pushed
the
export-D50615419
branch
from
ae9781e to
27cc16c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50615419 |
…t valid (pytorch#111961) Summary: There's no reason to terminate the parent process trying to find the name of the signal received by the child process. Let's make sure this is handled properly, which then will ensure that parent process can process child failures. Test Plan: Unit tests. Reviewed By: aaronenyeshi Differential Revision: D50615419
atuljangra
force-pushed
the
export-D50615419
branch
from
27cc16c to
64a9f4a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50615419 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…t valid (pytorch#111961) Summary: There's no reason to terminate the parent process trying to find the name of the signal received by the child process. Let's make sure this is handled properly, which then will ensure that parent process can process child failures. Test Plan: Unit tests. Reviewed By: aaronenyeshi Differential Revision: D50615419 Pull Request resolved: pytorch#111961 Approved by: https://github.com/aaronenyeshi
…t valid (pytorch#111961) Summary: There's no reason to terminate the parent process trying to find the name of the signal received by the child process. Let's make sure this is handled properly, which then will ensure that parent process can process child failures. Test Plan: Unit tests. Reviewed By: aaronenyeshi Differential Revision: D50615419 Pull Request resolved: pytorch#111961 Approved by: https://github.com/aaronenyeshi
4 participants
Summary:
There's no reason to terminate the parent process trying to find the name of the signal received by the child process.
Let's make sure this is handled properly, which then will ensure that parent process can process child failures.
Test Plan: Unit tests.
Reviewed By: aaronenyeshi
Differential Revision: D50615419