KEMBAR78
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo by BowenBao · Pull Request #111978 · pytorch/pytorch · GitHub
Skip to content

Support 'BaseOutput' and subclasses from 'diffusers' in dynamo #111978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Support 'BaseOutput' and subclasses from 'diffusers' in dynamo #111978

wants to merge 5 commits into from

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Oct 24, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Extending the workarounds for transformers ModelOutput to cover diffusers BaseOutput. Together with huggingface/diffusers#5459 it should unblock export for diffusers models.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng

@BowenBao BowenBao mentioned this pull request Oct 24, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111978

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8362bed with merge base e36daca (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@BowenBao BowenBao mentioned this pull request Oct 24, 2023
Closed
@BowenBao BowenBao added the topic: new features topic category label Oct 24, 2023
@BowenBao
Update on "Support 'BaseOutput' and subclasses from 'diffusers' in dy…
2a2a734 
…namo"


Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models.


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Oct 24, 2023
@BowenBao
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo
7f352b5 
ghstack-source-id: 54caa08
Pull Request resolved: #111978
@BowenBao BowenBao marked this pull request as ready for review October 24, 2023 23:31
@BowenBao
Update on "Support 'BaseOutput' and subclasses from 'diffusers' in dy…
ed380b5 
…namo"


Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models.


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Oct 26, 2023
@BowenBao
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo
b23803b 
ghstack-source-id: 0799c2f
Pull Request resolved: #111978
@BowenBao BowenBao requested a review from jansel October 26, 2023 20:51
@BowenBao
Copy link
Collaborator Author

@jansel PTAL, thanks!

@BowenBao BowenBao marked this pull request as draft October 26, 2023 23:51
This was referenced Oct 27, 2023
Closed
Closed
Closed
jansel
jansel requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing?

@BowenBao
Copy link
Collaborator Author

There are some weird segfaults happening in CI, I'm trying to debug. So far I cannot repro on my end, but it seems consistent on CI machines.

@BowenBao BowenBao mentioned this pull request Oct 27, 2023
Closed
@BowenBao
Squash experimenting changes; on "Support 'BaseOutput' and subclasses…
7d87104 
… from 'diffusers' in dynamo"


Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models.


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Oct 27, 2023
@BowenBao
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo
5ed6edf 
ghstack-source-id: 6548b7c
Pull Request resolved: #111978
BowenBao added a commit that referenced this pull request Oct 27, 2023
@BowenBao
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo
34fa2be 
ghstack-source-id: 6548b7c
Pull Request resolved: #111978
@BowenBao BowenBao marked this pull request as ready for review October 28, 2023 02:18
@BowenBao BowenBao requested a review from jansel October 28, 2023 02:19
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 28, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 5ed6edfaadc17d027d4324b4a837f992c7838f3f returned non-zero exit code 1

Auto-merging torch/_dynamo/variables/dicts.py
CONFLICT (content): Merge conflict in torch/_dynamo/variables/dicts.py
error: could not apply 5ed6edfaadc... Support 'BaseOutput' and subclasses from 'diffusers' in dynamo
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@BowenBao
rebase on "Support 'BaseOutput' and subclasses from 'diffusers' in dy…
8362bed 
…namo"


Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models.


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Oct 30, 2023
@BowenBao
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo
e18caa3 
ghstack-source-id: 914e0a4
Pull Request resolved: #111978
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/308/head branch November 3, 2023 14:26
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@BowenBao @xuhancn
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo (pytor…
72a9cc2 
…ch#111978)

Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models.

Pull Request resolved: pytorch#111978
Approved by: https://github.com/jansel
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@BowenBao @Skylion007
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo (pytor…
39fae7b 
…ch#111978)

Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models.

Pull Request resolved: pytorch#111978
Approved by: https://github.com/jansel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source release notes: dynamo topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BowenBao @pytorchmergebot @jansel @pytorchbot