Don't search getitem for batch fusions #112088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112088
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 75e3ee6 with merge base b332200 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mlazos
added
release notes: inductor
ciflow/trunk
|
@jackiexu1992 Can you double check if this impacts Ads model pattern searching? |
|
@mlazos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
yanboliang
approved these changes
Oct 25, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Batch mm fusion regressed optimizer compile time by about ~1m, excluding getitem solves this problem. Pull Request resolved: pytorch#112088 Approved by: https://github.com/yanboliang
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Batch mm fusion regressed optimizer compile time by about ~1m, excluding getitem solves this problem. Pull Request resolved: pytorch#112088 Approved by: https://github.com/yanboliang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch mm fusion regressed optimizer compile time by about ~1m, excluding getitem solves this problem.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler