[Experimental][ONNX] Export with symbolic shapes in proto #112179

BowenBao · 2023-10-26T18:31:29Z

Stack from ghstack (oldest at bottom):

Experimental feature to store symbolic shapes produced by torch dynamo inside the exported onnx model.
There is no official ONNX spec to support nodes within FunctionProto to have value info, onnx/onnx#5487. The names for value info are generated uniquely to be retrievable based on the call site and call stack.
This requires onnxscript with https://github.com/microsoft/onnxscript/tree/bowbao/export_symbolic_shapes

[ghstack-poisoned]

pytorch-bot · 2023-10-26T18:31:32Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112179

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4459e9c with merge base b6a30bb ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: ec192c8 Pull Request resolved: #112179

[ghstack-poisoned]

torch/onnx/_internal/fx/fx_onnx_interpreter.py

…ith symbolic shapes in proto" Experimental feature to store symbolic shapes produced by torch dynamo inside the exported onnx model. There is no official ONNX spec to support nodes within FunctionProto to have value info, onnx/onnx#5487. The names for value info are generated uniquely to be retrievable based on the call site and call stack. This requires onnxscript with https://github.com/microsoft/onnxscript/tree/bowbao/export_symbolic_shapes [ghstack-poisoned]

ghstack-source-id: dccf5c8 Pull Request resolved: #112179

Experimental feature to store symbolic shapes produced by torch dynamo inside the exported onnx model. There is no official ONNX spec to support nodes within FunctionProto to have value info, onnx/onnx#5487. The names for value info are generated uniquely to be retrievable based on the call site and call stack. This requires onnxscript with https://github.com/microsoft/onnxscript/tree/bowbao/export_symbolic_shapes [ghstack-poisoned]

ghstack-source-id: 8f12ad9 Pull Request resolved: #112179

…Export with symbolic shapes in proto" Experimental feature to store symbolic shapes produced by torch dynamo inside the exported onnx model. There is no official ONNX spec to support nodes within FunctionProto to have value info, onnx/onnx#5487. The names for value info are generated uniquely to be retrievable based on the call site and call stack. This requires onnxscript with https://github.com/microsoft/onnxscript/tree/bowbao/export_symbolic_shapes [ghstack-poisoned]

ghstack-source-id: a22c9c2 Pull Request resolved: #112179

titaiwangms · 2023-11-22T19:58:58Z

This requires onnxscript with https://github.com/microsoft/onnxscript/tree/bowbao/export_symbolic_shapes

The link doesn't work on my side. Is it a PR in onnxscript?

titaiwangms · 2023-11-22T20:13:39Z

This requires onnxscript with https://github.com/microsoft/onnxscript/tree/bowbao/export_symbolic_shapes

The link doesn't work on my side. Is it a PR in onnxscript?

Found it. It's merged.

.ci/docker/common/install_onnx.sh

torch/onnx/_internal/fx/fx_onnx_interpreter.py

ghstack-source-id: a22c9c2 Pull Request resolved: #112179

BowenBao · 2023-11-29T18:20:20Z

@pytorchbot merge

pytorchmergebot · 2023-11-29T18:22:26Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-11-29T18:38:37Z

Merge failed

Reason: 1 jobs have failed, first few of them are: docker-builds / docker-build (pytorch-linux-focal-rocm-n-1-py3)

Details for Dev Infra team

Raised by workflow job

BowenBao · 2023-11-30T00:05:13Z

@pytorchbot merge

pytorchmergebot · 2023-11-30T00:07:20Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-11-30T00:07:36Z

Merge failed

Reason: 1 jobs have failed, first few of them are: docker-builds / docker-build (pytorch-linux-focal-rocm-n-1-py3)

Details for Dev Infra team

Raised by workflow job

BowenBao · 2023-11-30T02:01:24Z

@pytorchbot merge

pytorchmergebot · 2023-11-30T02:03:13Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: #114767 Approved by: https://github.com/thiagocrepaldi ghstack dependencies: #112179

Increases perf accuracy especially for low iteration runs. Pull Request resolved: #114821 Approved by: https://github.com/thiagocrepaldi ghstack dependencies: #112179, #114767

ghstack-source-id: 81bd276 Pull Request resolved: pytorch/pytorch#112179

…2179) Experimental feature to store symbolic shapes produced by torch dynamo inside the exported onnx model. There is no official ONNX spec to support nodes within FunctionProto to have value info, onnx/onnx#5487. The names for value info are generated uniquely to be retrievable based on the call site and call stack. This requires onnxscript with https://github.com/microsoft/onnxscript/tree/bowbao/export_symbolic_shapes Pull Request resolved: pytorch#112179 Approved by: https://github.com/titaiwangms, https://github.com/thiagocrepaldi

Pull Request resolved: pytorch#114767 Approved by: https://github.com/thiagocrepaldi ghstack dependencies: pytorch#112179

Increases perf accuracy especially for low iteration runs. Pull Request resolved: pytorch#114821 Approved by: https://github.com/thiagocrepaldi ghstack dependencies: pytorch#112179, pytorch#114767

thiagocrepaldi · 2024-01-17T16:33:07Z

Was https://github.com/microsoft/onnxscript/tree/bowbao/export_symbolic_shapes ever merged into main?

[Experimental][ONNX] Export with symbolic shapes in proto

fa58319

[ghstack-poisoned]

pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 26, 2023

pytorchbot added the open source label Oct 26, 2023

BowenBao added a commit that referenced this pull request Oct 26, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

5cd4282

ghstack-source-id: ec192c8 Pull Request resolved: #112179

BowenBao added a commit that referenced this pull request Nov 3, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

4ab5507

ghstack-source-id: ec192c8 Pull Request resolved: #112179

BowenBao added a commit that referenced this pull request Nov 10, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

4d083b7

ghstack-source-id: ec192c8 Pull Request resolved: #112179

BowenBao added a commit that referenced this pull request Nov 18, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

d6983fd

ghstack-source-id: ec192c8 Pull Request resolved: #112179

Update on "[Experimental][ONNX] Export with symbolic shapes in proto"

493d75a

[ghstack-poisoned]

Update on "[Experimental][ONNX] Export with symbolic shapes in proto"

7f74aa0

[ghstack-poisoned]

BowenBao commented Nov 21, 2023

View reviewed changes

torch/onnx/_internal/fx/fx_onnx_interpreter.py Show resolved Hide resolved

BowenBao added a commit that referenced this pull request Nov 21, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

857510c

ghstack-source-id: dccf5c8 Pull Request resolved: #112179

BowenBao added a commit that referenced this pull request Nov 21, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

986757a

ghstack-source-id: 8f12ad9 Pull Request resolved: #112179

BowenBao marked this pull request as ready for review November 21, 2023 22:35

BowenBao requested review from abock, jeffdaily, thiagocrepaldi and wschin as code owners November 21, 2023 22:35

BowenBao added the topic: new features topic category label Nov 21, 2023

BowenBao added a commit that referenced this pull request Nov 22, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

48049a2

ghstack-source-id: a22c9c2 Pull Request resolved: #112179

titaiwangms approved these changes Nov 22, 2023

View reviewed changes

.ci/docker/common/install_onnx.sh Outdated Show resolved Hide resolved

torch/onnx/_internal/fx/fx_onnx_interpreter.py Show resolved Hide resolved

BowenBao added a commit that referenced this pull request Nov 25, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

5cb0538

ghstack-source-id: a22c9c2 Pull Request resolved: #112179

BowenBao mentioned this pull request Nov 29, 2023

[ONNX][Bench] Relax tolerance for cuda accuracy check #114767

Closed

pytorchmergebot added the merging label Nov 29, 2023

pytorchmergebot removed the merging label Nov 29, 2023

pytorchmergebot added the merging label Nov 30, 2023

pytorchmergebot removed the merging label Nov 30, 2023

pytorchmergebot added the merging label Nov 30, 2023

pytorchmergebot added the Merged label Nov 30, 2023

pytorchmergebot removed the merging label Nov 30, 2023

pytorchmergebot closed this in 8cfc953 Nov 30, 2023

BowenBao mentioned this pull request Nov 30, 2023

[ONNX][Bench] Add warmup for onnx cuda runs #114821

Closed

pytorchmergebot pushed a commit that referenced this pull request Nov 30, 2023

[ONNX][Bench] Relax tolerance for cuda accuracy check (#114767)

c1e51fc

Pull Request resolved: #114767 Approved by: https://github.com/thiagocrepaldi ghstack dependencies: #112179

facebook-github-bot deleted the gh/BowenBao/310/head branch December 3, 2023 15:26

tmavima2251 pushed a commit to tmavima2251/Pytorch that referenced this pull request Dec 8, 2023

[Experimental][ONNX] Export with symbolic shapes in proto

004f8c8

ghstack-source-id: 81bd276 Pull Request resolved: pytorch/pytorch#112179

dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023

[ONNX][Bench] Relax tolerance for cuda accuracy check (pytorch#114767)

99fd5a2

Pull Request resolved: pytorch#114767 Approved by: https://github.com/thiagocrepaldi ghstack dependencies: pytorch#112179

[Experimental][ONNX] Export with symbolic shapes in proto #112179

[Experimental][ONNX] Export with symbolic shapes in proto #112179

Uh oh!

Conversation

BowenBao commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112179

✅ No Failures

Uh oh!

Uh oh!

titaiwangms commented Nov 22, 2023

Uh oh!

titaiwangms commented Nov 22, 2023

Uh oh!

Uh oh!

Uh oh!

BowenBao commented Nov 29, 2023

Uh oh!

pytorchmergebot commented Nov 29, 2023

Merge started

Uh oh!

pytorchmergebot commented Nov 29, 2023

Merge failed

Uh oh!

BowenBao commented Nov 30, 2023

Uh oh!

pytorchmergebot commented Nov 30, 2023

Merge started

Uh oh!

pytorchmergebot commented Nov 30, 2023

Merge failed

Uh oh!

BowenBao commented Nov 30, 2023

Uh oh!

pytorchmergebot commented Nov 30, 2023

Merge started

Uh oh!

thiagocrepaldi commented Jan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BowenBao commented Oct 26, 2023 •

edited

Loading

pytorch-bot bot commented Oct 26, 2023 •

edited

Loading