Reland "[aot inductor] Move constant loading logic from Container to Model" #112197

bertmaher · 2023-10-26T21:05:28Z

Stack from ghstack (oldest at bottom):

-> Reland "[aot inductor] Move constant loading logic from Container to Model" #112197

Trying again, hopefully with 100% fewer merge conflicts

Original diff: D50582959
Revert diff: D50657400

Differential Revision: D50710815

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler

…Model" Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/) [ghstack-poisoned]

pytorch-bot · 2023-10-26T21:05:32Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112197

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 60713a3 with merge base 220c3ba ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…Model" Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/) ghstack-source-id: 205507248 Pull Request resolved: #112197

chenyang78 · 2023-10-27T06:06:34Z

Hmm, based on the test names, seems some accuracy failures are related to this change.

…ntainer to Model"" Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]

…Model" Pull Request resolved: #112197 Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 ghstack-source-id: 01c7221 @exported-using-ghexport Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/)

bertmaher · 2023-11-06T15:08:30Z

@pytorchbot merge

pytorchmergebot · 2023-11-06T15:10:43Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team

Raised by workflow job

bertmaher · 2023-11-06T15:13:03Z

@pytorchbot merge -f 'it does not have internal changes'

pytorchmergebot · 2023-11-06T15:15:01Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-11-06T15:15:17Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team

Raised by workflow job

…ntainer to Model"" Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]

…Model" Pull Request resolved: #112197 Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 ghstack-source-id: 206568460 @exported-using-ghexport Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/)

bertmaher · 2023-11-06T16:59:46Z

@pytorchbot merge

pytorchmergebot · 2023-11-06T17:02:09Z

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

bertmaher · 2023-11-06T17:03:08Z

@pytorchbot merge

pytorchmergebot · 2023-11-06T17:05:17Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-11-06T17:05:32Z

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

…ntainer to Model"" Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]

…Model" Pull Request resolved: #112197 Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 ghstack-source-id: c1f4ebc @exported-using-ghexport Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/)

bertmaher · 2023-11-07T19:18:41Z

@bertmaher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

bertmaher · 2023-11-08T15:05:53Z

@pytorchbot merge

pytorchmergebot · 2023-11-08T15:07:53Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…Model" (pytorch#112197) Trying again, hopefully with 100% fewer merge conflicts Original diff: D50582959 Revert diff: D50657400 Differential Revision: [D50710815](https://our.internmc.facebook.com/intern/diff/D50710815/) Pull Request resolved: pytorch#112197 Approved by: https://github.com/desertfire, https://github.com/chenyang78

github-actions bot added module: inductor ciflow/inductor labels Oct 26, 2023

bertmaher requested review from chenyang78, desertfire and muchulee8 October 26, 2023 21:05

desertfire approved these changes Nov 3, 2023

View reviewed changes

chenyang78 approved these changes Nov 3, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 6, 2023

pytorchmergebot added the merging label Nov 6, 2023

pytorchmergebot removed the merging label Nov 6, 2023

pytorchmergebot added the merging label Nov 6, 2023

pytorchmergebot removed the merging label Nov 6, 2023

pytorchmergebot added the merging label Nov 6, 2023

pytorchmergebot removed the merging label Nov 6, 2023

bertmaher added the topic: not user facing topic category label Nov 6, 2023

pytorchmergebot added the merging label Nov 6, 2023

pytorchmergebot removed the merging label Nov 6, 2023

pytorchmergebot added the merging label Nov 8, 2023

pytorchmergebot added Merged and removed merging labels Nov 8, 2023

pytorchmergebot closed this in 9bda1e8 Nov 8, 2023

facebook-github-bot deleted the gh/bertmaher/187/head branch November 11, 2023 15:24

Reland "[aot inductor] Move constant loading logic from Container to Model" #112197

Reland "[aot inductor] Move constant loading logic from Container to Model" #112197

Uh oh!

Conversation

bertmaher commented Oct 26, 2023 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112197

✅ No Failures

Uh oh!

chenyang78 commented Oct 27, 2023

Uh oh!

bertmaher commented Nov 6, 2023

Uh oh!

pytorchmergebot commented Nov 6, 2023

Merge failed

Uh oh!

bertmaher commented Nov 6, 2023

Uh oh!

pytorchmergebot commented Nov 6, 2023

Merge started

Uh oh!

pytorchmergebot commented Nov 6, 2023

Merge failed

Uh oh!

bertmaher commented Nov 6, 2023

Uh oh!

pytorchmergebot commented Nov 6, 2023

Merge failed

Uh oh!

bertmaher commented Nov 6, 2023

Uh oh!

pytorchmergebot commented Nov 6, 2023

Merge started

Uh oh!

pytorchmergebot commented Nov 6, 2023

Merge failed

Uh oh!

bertmaher commented Nov 7, 2023

Uh oh!

bertmaher commented Nov 8, 2023

Uh oh!

pytorchmergebot commented Nov 8, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bertmaher commented Oct 26, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Oct 26, 2023 •

edited

Loading