-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[dtensor] Introduce full_tensor API to DTensor #112224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR introduces a `full_tensor` API to DTensor, there were so many callsites that exercises the `redistribute(replicate)` path and I feel it deserves a separate API, mostly just a syntactic sugar [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112224
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1cdc187 with merge base bf01a7b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR introduces a `full_tensor` API to DTensor, there were so many callsites that exercises the `redistribute(replicate)` path and I feel it deserves a separate API, mostly just a syntactic sugar [ghstack-poisoned]
This PR introduces a `full_tensor` API to DTensor, there were so many callsites that exercises the `redistribute(replicate)` path and I feel it deserves a separate API, mostly just a syntactic sugar [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!!! LGTM!
I will follow up to change some of the state dict stuff to use full_tensor API then!
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This PR introduces a `full_tensor` API to DTensor, there were so many callsites that exercises the `redistribute(replicate)` path and I feel it deserves a separate API, mostly just a syntactic sugar Pull Request resolved: pytorch#112224 Approved by: https://github.com/wz337
This PR introduces a `full_tensor` API to DTensor, there were so many callsites that exercises the `redistribute(replicate)` path and I feel it deserves a separate API, mostly just a syntactic sugar Pull Request resolved: pytorch#112224 Approved by: https://github.com/wz337
Stack from ghstack (oldest at bottom):
This PR introduces a
full_tensorAPI to DTensor, there were so manycallsites that exercises the
redistribute(replicate)path and I feelit deserves a separate API, mostly just a syntactic sugar