Support for as_nested_tensor() with jagged layout + fixed nested_tensor() semantics #112304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or() semantics [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112304
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 58f0798 with merge base 128f4db ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jbschlosser
added
topic: improvements
cpuhrsch
approved these changes
Oct 27, 2023
|
@pytorchbot merge |
|
Thanks for sending this! I think it looks good. Good follow up work for |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
52 tasks
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…or() semantics (pytorch#112304) This PR: * Adds support for the `layout` kwarg to `torch.nested.as_nested_tensor()` * Fixes `torch.nested.nested_tensor()` * It should accept a list of lists of scalars * It should not preserve autograd history * Adds extensive testing for these two functions Semantics for the two functions follow those of the strided layout: * `torch.nested.nested_tensor(tensor_list, layout=torch.jagged)`: Creates a new jagged layout NT **with no autograd history** * `tensor_list` can be a list of Tensors or list of lists of scalars * `torch.nested.as_nested_tensor(tensor_list, layout=torch.jagged)`: Creates a new jagged layout NT **preserving autograd history of `tensor_list`** * `tensor_list` must be a list of Tensors Pull Request resolved: pytorch#112304 Approved by: https://github.com/cpuhrsch, https://github.com/soulitzer
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…or() semantics (pytorch#112304) This PR: * Adds support for the `layout` kwarg to `torch.nested.as_nested_tensor()` * Fixes `torch.nested.nested_tensor()` * It should accept a list of lists of scalars * It should not preserve autograd history * Adds extensive testing for these two functions Semantics for the two functions follow those of the strided layout: * `torch.nested.nested_tensor(tensor_list, layout=torch.jagged)`: Creates a new jagged layout NT **with no autograd history** * `tensor_list` can be a list of Tensors or list of lists of scalars * `torch.nested.as_nested_tensor(tensor_list, layout=torch.jagged)`: Creates a new jagged layout NT **preserving autograd history of `tensor_list`** * `tensor_list` must be a list of Tensors Pull Request resolved: pytorch#112304 Approved by: https://github.com/cpuhrsch, https://github.com/soulitzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR:
layoutkwarg totorch.nested.as_nested_tensor()torch.nested.nested_tensor()Semantics for the two functions follow those of the strided layout:
torch.nested.nested_tensor(tensor_list, layout=torch.jagged): Creates a new jagged layout NT with no autograd historytensor_listcan be a list of Tensors or list of lists of scalarstorch.nested.as_nested_tensor(tensor_list, layout=torch.jagged): Creates a new jagged layout NT preserving autograd history oftensor_listtensor_listmust be a list of Tensors