KEMBAR78
grid_sample: support bfloat16 by d4l3k · Pull Request #112331 · pytorch/pytorch · GitHub
Skip to content

Conversation

@d4l3k
Copy link
Member

@d4l3k d4l3k commented Oct 29, 2023

This adds bfloat16 support to torch.nn.functional.grid_sample this is particularly important when doing feature sampling such as for rendering techniques used in PyTorch3d or for camera projections to voxel grids such as in SimpleBEV.

Related to #57707

Test plan:

pytest test/test_nn.py -k grid_sample
pytest test/test_ops.py -k grid_sample

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Oct 29, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112331

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7313299 with merge base a380bf3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@d4l3k d4l3k requested a review from Chillee October 29, 2023 02:25
@d4l3k d4l3k force-pushed the grid_sample_bfloat16 branch from fdc80e2 to 7313299 Compare October 29, 2023 02:27
@d4l3k d4l3k requested a review from mruberry as a code owner October 29, 2023 02:27
@d4l3k d4l3k added the enhancement Not as big of a feature, but technically not a bug. Should be easy to fix label Oct 29, 2023
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 30, 2023
@d4l3k
Copy link
Member Author

d4l3k commented Oct 30, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 30, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@d4l3k d4l3k deleted the grid_sample_bfloat16 branch October 30, 2023 19:48
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
This adds bfloat16 support to `torch.nn.functional.grid_sample` this is particularly important when doing feature sampling such as for rendering techniques used in PyTorch3d or for camera projections to voxel grids such as in SimpleBEV.

Related to pytorch#57707

Test plan:

```
pytest test/test_nn.py -k grid_sample
pytest test/test_ops.py -k grid_sample
```
Pull Request resolved: pytorch#112331
Approved by: https://github.com/zou3519
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
This adds bfloat16 support to `torch.nn.functional.grid_sample` this is particularly important when doing feature sampling such as for rendering techniques used in PyTorch3d or for camera projections to voxel grids such as in SimpleBEV.

Related to pytorch#57707

Test plan:

```
pytest test/test_nn.py -k grid_sample
pytest test/test_ops.py -k grid_sample
```
Pull Request resolved: pytorch#112331
Approved by: https://github.com/zou3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request enhancement Not as big of a feature, but technically not a bug. Should be easy to fix Merged open source release notes: nn release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants