KEMBAR78
[DTensor] Assert shard dim is less than tensor ndim by joshlk · Pull Request #112404 · pytorch/pytorch · GitHub
Skip to content

Conversation

@joshlk
Copy link
Contributor

@joshlk joshlk commented Oct 30, 2023

Assert shard dim is less than tensor ndim. Previously, an index error on line 154 is thrown and the error is not clear

cc: @wanchaol

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112404

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit e7a2d86 with merge base d6724a5 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wanchaol wanchaol added the release notes: distributed (dtensor) release notes category label Oct 30, 2023
@joshlk
Copy link
Contributor Author

joshlk commented Oct 31, 2023

CLA issue has now been resolved. it should be ready to merge

@fduwjj
Copy link
Contributor

fduwjj commented Oct 31, 2023

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-focal-py3-clang9-android-ndk-r21e-gradle-custom-build-single / build-and-test (default, 1, 1, linux.2xlarge), pull / linux-focal-py3-clang9-android-ndk-r21e-gradle-custom-build-single-full-jit / build-and-test (default, 1, 1, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
Assert shard dim is less than tensor ndim. Previously, an index error on line 154 is thrown and the error is not clear

Pull Request resolved: pytorch#112404
Approved by: https://github.com/wanchaol, https://github.com/fduwjj
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
Assert shard dim is less than tensor ndim. Previously, an index error on line 154 is thrown and the error is not clear

Pull Request resolved: pytorch#112404
Approved by: https://github.com/wanchaol, https://github.com/fduwjj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: distributed (dtensor) release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants