[reland][quant][pt2e][be] Cleanup observer insertion logic (#111828) #112453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11828) Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709 Test plan from GitHub: python test/test_quantization.py TestQuantizePT2E CIs Differential Revision: D50816224 Pulled By: jerryzh168
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112453
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8410854 with merge base 40569b2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D50816224 |
andrewor14
approved these changes
Oct 31, 2023
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…11828) (pytorch#112453) Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709 Test plan from GitHub: python test/test_quantization.py TestQuantizePT2E CIs Differential Revision: D50816224 Pulled By: jerryzh168 Pull Request resolved: pytorch#112453 Approved by: https://github.com/andrewor14
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…11828) (pytorch#112453) Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709 Test plan from GitHub: python test/test_quantization.py TestQuantizePT2E CIs Differential Revision: D50816224 Pulled By: jerryzh168 Pull Request resolved: pytorch#112453 Approved by: https://github.com/andrewor14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers
Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709
Test plan from GitHub:
python test/test_quantization.py TestQuantizePT2E
CIs
Differential Revision: D50816224
Pulled By: jerryzh168