[Inductor] [Quant] Enable QConv2d Unary int8-mixed-bf16 Lowering #112550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112550
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c6718ec with merge base 8bdce9b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 1, 2023
This was referenced Nov 1, 2023
jgong5
reviewed
Nov 1, 2023
leslie-fang-intel
added a commit
to leslie-fang-intel/pytorch
that referenced
this pull request
Nov 2, 2023
ghstack-source-id: f5bbb4a Pull Request resolved: pytorch#112550
…wering" **Summary** - PR 5 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QConv2d Unary int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
to leslie-fang-intel/pytorch
that referenced
this pull request
Nov 3, 2023
ghstack-source-id: 1838155 Pull Request resolved: pytorch#112550
…wering" **Summary** - PR 5 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QConv2d Unary int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
leslie-fang-intel
added a commit
to leslie-fang-intel/pytorch
that referenced
this pull request
Nov 3, 2023
ghstack-source-id: 8e8e9d1 Pull Request resolved: pytorch#112550
…wering" **Summary** - PR 5 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QConv2d Unary int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
…wering" **Summary** - PR 5 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QConv2d Unary int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
jgong5
approved these changes
Nov 5, 2023
|
Hi @eellison @jerryzh168, Could you kindly help to review these 3 PRs in this ghstack for the Inductor lowering of int8-mixed-bf16 quantization case? |
|
@jerryzh168 want to review this one ? |
jerryzh168
reviewed
Nov 9, 2023
jerryzh168
reviewed
Nov 9, 2023
jerryzh168
reviewed
Nov 9, 2023
jerryzh168
reviewed
Nov 9, 2023
jerryzh168
reviewed
Nov 9, 2023
jerryzh168
reviewed
Nov 9, 2023
jerryzh168
reviewed
Nov 9, 2023
jerryzh168
approved these changes
Nov 9, 2023
…wering" **Summary** - PR 5 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QConv2d Unary int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d ``` cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 10, 2023
…12551) **Summary** - PR 6 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor #111640. - Enable the QConv2d Binary int8-mixed-bf16 post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d ``` Pull Request resolved: #112551 Approved by: https://github.com/jgong5, https://github.com/eellison, https://github.com/jerryzh168 ghstack dependencies: #112550
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…orch#112550) **Summary** - PR 5 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor pytorch#111640. - Enable the QConv2d Unary int8-mixed-bf16 weight prepack and post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d ``` Pull Request resolved: pytorch#112550 Approved by: https://github.com/jgong5, https://github.com/jerryzh168
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…torch#112551) **Summary** - PR 6 for enabling Int8-Mixed-BF16 PT2E PTQ Quantization with Inductor pytorch#111640. - Enable the QConv2d Binary int8-mixed-bf16 post grad lowering inside inductor. **TestPlan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d ``` Pull Request resolved: pytorch#112551 Approved by: https://github.com/jgong5, https://github.com/eellison, https://github.com/jerryzh168 ghstack dependencies: pytorch#112550
k-artem
added a commit
to ROCm/pytorch
that referenced
this pull request
Jun 13, 2025
* Most part of testcases work properly on Navi48(gfx1201) with TORCH_ROCM_AOTRITON_ENABLE_EXPERIMENTAL=1, in this commit enable it for this arch. No support of AOTriton currently for Navci44(gfx1200), so these testcases just skipped. * test_qconv2d_int8_mixed_bf16 skipped because it was originally skipped in pytorch#112550 but later lost. * test_sac_ilp_case1 skipped as per SWDEV-509011 * test_distributed_checkpoint_state_dict_type[0-1]_cuda fixed bug with arguments.
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 7, 2025
… SDPA or Navi4x (#2213) [release/2.6][SWDEV-523736] Skip some testcases for archs without SDPA or Navi4x [SWDEV-523736] Fix some unittests for Navi4x * Most part of testcases work properly on Navi48(gfx1201) with TORCH_ROCM_AOTRITON_ENABLE_EXPERIMENTAL=1, in this commit enable it for this arch. No support of AOTriton currently for Navci44(gfx1200), so these testcases just skipped. * test_qconv2d_int8_mixed_bf16 skipped because it was originally skipped in pytorch#112550 but later lost. * test_sac_ilp_case1 skipped as per SWDEV-509011 * test_distributed_checkpoint_state_dict_type[0-1]_cuda fixed bug with arguments. Fixes #SWDEV-523736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
TestPlan
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler