[Cmake] Check that gcc-9.4 or newer is used #112858
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112858
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit fa97acc with merge base 3e2c941 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added
release notes: build
As this is the first one that is fully compatible with C++17 standard Fixes #101839
malfet
force-pushed
the
malfet/bump-min-gcc-to-9
branch
from
d89acf3 to
8987c99
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "breaking internal tests (check diff for test page)" -c "ghfirst" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@malfet your PR has been successfully reverted. |
Reverting PR 112858 failedReason: HTTP Error 422: Unprocessable Entity Details for Dev Infra teamRaised by workflow job |
This reverts commit ad894cd. Reverted #112858 on behalf of https://github.com/PaliC due to breaking internal tests (check diff for test page) ([comment](#112858 (comment)))
|
@pytorchbot merge -f "It passes the abovementioned test" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
As this is the oldest gcc that is fully compatible with C++17 standard. - Replace number of conditional version with simpler `if(CMAKE_COMPILER_IS_GNUCXX)` or `append_cxx_flag_if_supported`. - As `-Wsuggest-override` condition was hidden before incorrect guard, add missing `override` keywords to `torch::autograd::PyFunctionTensorPostAccGradHooks::apply_with_saved` , `caffe2::python::TensorFeeder::Feed` and `cafee2::NetObserverReporterPrint::report``` Fixes pytorch#101839 Pull Request resolved: pytorch#112858 Approved by: https://github.com/Skylion007, https://github.com/albanD
This reverts commit ad894cd. Reverted pytorch#112858 on behalf of https://github.com/PaliC due to breaking internal tests (check diff for test page) ([comment](pytorch#112858 (comment)))
As this is the oldest gcc that is fully compatible with C++17 standard. - Replace number of conditional version with simpler `if(CMAKE_COMPILER_IS_GNUCXX)` or `append_cxx_flag_if_supported`. - As `-Wsuggest-override` condition was hidden before incorrect guard, add missing `override` keywords to `torch::autograd::PyFunctionTensorPostAccGradHooks::apply_with_saved` , `caffe2::python::TensorFeeder::Feed` and `cafee2::NetObserverReporterPrint::report``` Fixes pytorch#101839 Pull Request resolved: pytorch#112858 Approved by: https://github.com/Skylion007, https://github.com/albanD
As this is the oldest gcc that is fully compatible with C++17 standard. - Replace number of conditional version with simpler `if(CMAKE_COMPILER_IS_GNUCXX)` or `append_cxx_flag_if_supported`. - As `-Wsuggest-override` condition was hidden before incorrect guard, add missing `override` keywords to `torch::autograd::PyFunctionTensorPostAccGradHooks::apply_with_saved` , `caffe2::python::TensorFeeder::Feed` and `cafee2::NetObserverReporterPrint::report``` Fixes pytorch#101839 Pull Request resolved: pytorch#112858 Approved by: https://github.com/Skylion007, https://github.com/albanD
This reverts commit ad894cd. Reverted pytorch#112858 on behalf of https://github.com/PaliC due to breaking internal tests (check diff for test page) ([comment](pytorch#112858 (comment)))
As this is the oldest gcc that is fully compatible with C++17 standard. - Replace number of conditional version with simpler `if(CMAKE_COMPILER_IS_GNUCXX)` or `append_cxx_flag_if_supported`. - As `-Wsuggest-override` condition was hidden before incorrect guard, add missing `override` keywords to `torch::autograd::PyFunctionTensorPostAccGradHooks::apply_with_saved` , `caffe2::python::TensorFeeder::Feed` and `cafee2::NetObserverReporterPrint::report``` Fixes pytorch#101839 Pull Request resolved: pytorch#112858 Approved by: https://github.com/Skylion007, https://github.com/albanD
5 participants
As this is the oldest gcc that is fully compatible with C++17 standard.
if(CMAKE_COMPILER_IS_GNUCXX)orappend_cxx_flag_if_supported.-Wsuggest-overridecondition was hidden before incorrect guard, add missingoverridekeywords totorch::autograd::PyFunctionTensorPostAccGradHooks::apply_with_saved,caffe2::python::TensorFeeder::Feedand `cafee2::NetObserverReporterPrint::report```Fixes #101839