[pytorch-vulkan] conv1d, only handle special case #112880
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
ciflow/periodic
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112880
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 6551fe6 with merge base 46a34e8 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D50914117 |
manuelcandales
approved these changes
Nov 3, 2023
yipjustin
force-pushed
the
export-D50914117
branch
from
031cf97 to
97e0d2d
Compare
yipjustin
added a commit
to yipjustin/pytorch
that referenced
this pull request
Nov 3, 2023
Summary: Just enough to cover the requirement for our target use-case. Will add complete implementation later. Test Plan: ``` (base) yipjustin@yipjustin-mac fbsource % buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*conv1d*" File changed: fbsource//xplat/caffe2/aten/src/ATen/test/vulkan_api_test.cpp Buck UI: https://www.internalfb.com/buck2/27291bfe-940a-4bed-9616-8f3b4f2a3fc7 Network: Up: 20MiB Down: 142B (reSessionID-5632e058-9f48-40eb-8157-30e2db104272) Jobs completed: 6. Time elapsed: 13.5s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) BUILD SUCCEEDED Running main() from third-party/googletest/1.11.0/googletest/googletest/src/gtest_main.cc Note: Google Test filter = *conv1d* [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests from VulkanAPITest [ RUN ] VulkanAPITest.conv1d_simple [ OK ] VulkanAPITest.conv1d_simple (37 ms) [ RUN ] VulkanAPITest.conv1d [ OK ] VulkanAPITest.conv1d (2 ms) [----------] 2 tests from VulkanAPITest (39 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test suite ran. (39 ms total) [ PASSED ] 2 tests. ``` Reviewed By: manuelcandales Differential Revision: D50914117
|
This pull request was exported from Phabricator. Differential Revision: D50914117 |
yipjustin
force-pushed
the
export-D50914117
branch
from
97e0d2d to
fb47531
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50914117 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50914117 |
yipjustin
force-pushed
the
export-D50914117
branch
from
fb47531 to
553a706
Compare
yipjustin
added a commit
to yipjustin/pytorch
that referenced
this pull request
Nov 4, 2023
Summary: Just enough to cover the requirement for our target use-case. Will add complete implementation later. Test Plan: ``` (base) yipjustin@yipjustin-mac fbsource % buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*conv1d*" File changed: fbsource//xplat/caffe2/aten/src/ATen/test/vulkan_api_test.cpp Buck UI: https://www.internalfb.com/buck2/27291bfe-940a-4bed-9616-8f3b4f2a3fc7 Network: Up: 20MiB Down: 142B (reSessionID-5632e058-9f48-40eb-8157-30e2db104272) Jobs completed: 6. Time elapsed: 13.5s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) BUILD SUCCEEDED Running main() from third-party/googletest/1.11.0/googletest/googletest/src/gtest_main.cc Note: Google Test filter = *conv1d* [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests from VulkanAPITest [ RUN ] VulkanAPITest.conv1d_simple [ OK ] VulkanAPITest.conv1d_simple (37 ms) [ RUN ] VulkanAPITest.conv1d [ OK ] VulkanAPITest.conv1d (2 ms) [----------] 2 tests from VulkanAPITest (39 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test suite ran. (39 ms total) [ PASSED ] 2 tests. ``` Reviewed By: manuelcandales Differential Revision: D50914117
|
This pull request was exported from Phabricator. Differential Revision: D50914117 |
Summary: Just enough to cover the requirement for our target use-case. Will add complete implementation later. bypass-github-pytorch-ci-checks periodic / linux-focal-cuda11.8-py3.9-gcc9 / test is unrelated to this diff. Test Plan: ``` (base) yipjustin@yipjustin-mac fbsource % buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*conv1d*" File changed: fbsource//xplat/caffe2/aten/src/ATen/test/vulkan_api_test.cpp Buck UI: https://www.internalfb.com/buck2/27291bfe-940a-4bed-9616-8f3b4f2a3fc7 Network: Up: 20MiB Down: 142B (reSessionID-5632e058-9f48-40eb-8157-30e2db104272) Jobs completed: 6. Time elapsed: 13.5s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) BUILD SUCCEEDED Running main() from third-party/googletest/1.11.0/googletest/googletest/src/gtest_main.cc Note: Google Test filter = *conv1d* [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests from VulkanAPITest [ RUN ] VulkanAPITest.conv1d_simple [ OK ] VulkanAPITest.conv1d_simple (37 ms) [ RUN ] VulkanAPITest.conv1d [ OK ] VulkanAPITest.conv1d (2 ms) [----------] 2 tests from VulkanAPITest (39 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test suite ran. (39 ms total) [ PASSED ] 2 tests. ``` Reviewed By: manuelcandales Differential Revision: D50914117
|
This pull request was exported from Phabricator. Differential Revision: D50914117 |
yipjustin
force-pushed
the
export-D50914117
branch
from
553a706 to
6551fe6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50914117 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: Just enough to cover the requirement for our target use-case. Will add complete implementation later. Test Plan: ``` (base) yipjustin@yipjustin-mac fbsource % buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*conv1d*" File changed: fbsource//xplat/caffe2/aten/src/ATen/test/vulkan_api_test.cpp Buck UI: https://www.internalfb.com/buck2/27291bfe-940a-4bed-9616-8f3b4f2a3fc7 Network: Up: 20MiB Down: 142B (reSessionID-5632e058-9f48-40eb-8157-30e2db104272) Jobs completed: 6. Time elapsed: 13.5s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) BUILD SUCCEEDED Running main() from third-party/googletest/1.11.0/googletest/googletest/src/gtest_main.cc Note: Google Test filter = *conv1d* [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests from VulkanAPITest [ RUN ] VulkanAPITest.conv1d_simple [ OK ] VulkanAPITest.conv1d_simple (37 ms) [ RUN ] VulkanAPITest.conv1d [ OK ] VulkanAPITest.conv1d (2 ms) [----------] 2 tests from VulkanAPITest (39 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test suite ran. (39 ms total) [ PASSED ] 2 tests. ``` Differential Revision: D50914117 Pull Request resolved: pytorch#112880 Approved by: https://github.com/manuelcandales
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Summary: Just enough to cover the requirement for our target use-case. Will add complete implementation later. Test Plan: ``` (base) yipjustin@yipjustin-mac fbsource % buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*conv1d*" File changed: fbsource//xplat/caffe2/aten/src/ATen/test/vulkan_api_test.cpp Buck UI: https://www.internalfb.com/buck2/27291bfe-940a-4bed-9616-8f3b4f2a3fc7 Network: Up: 20MiB Down: 142B (reSessionID-5632e058-9f48-40eb-8157-30e2db104272) Jobs completed: 6. Time elapsed: 13.5s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) BUILD SUCCEEDED Running main() from third-party/googletest/1.11.0/googletest/googletest/src/gtest_main.cc Note: Google Test filter = *conv1d* [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests from VulkanAPITest [ RUN ] VulkanAPITest.conv1d_simple [ OK ] VulkanAPITest.conv1d_simple (37 ms) [ RUN ] VulkanAPITest.conv1d [ OK ] VulkanAPITest.conv1d (2 ms) [----------] 2 tests from VulkanAPITest (39 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test suite ran. (39 ms total) [ PASSED ] 2 tests. ``` Differential Revision: D50914117 Pull Request resolved: pytorch#112880 Approved by: https://github.com/manuelcandales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Just enough to cover the requirement for our target use-case.
Will add complete implementation later.
Test Plan:
Differential Revision: D50914117