[state_dict] Rewrite _gather_state_dict to extract the traversal logic #112885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
fegin
requested review from
H-Huang,
awgu,
d4l3k,
fduwjj,
kiukchung,
kwen2501,
mrshenli,
rohan-varma,
wanchaol,
wz337 and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112885
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ce8efd0 with merge base 31ded95 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fegin
added
ciflow/trunk
…versal logic" This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
…versal logic" This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
…versal logic" This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
…versal logic" This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
…versal logic" This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
…versal logic" This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
…versal logic" This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
wz337
approved these changes
Nov 9, 2023
…versal logic" This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) [ghstack-poisoned]
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 13, 2023
…state_dict (#112837) As title Differential Revision: [D50962991](https://our.internmc.facebook.com/intern/diff/D50962991/) Pull Request resolved: #112837 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: #112836, #112885
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
pytorch#112885) This allows us to do cpu_offload with the same traversal logic Differential Revision: [D50982355](https://our.internmc.facebook.com/intern/diff/D50982355/) Pull Request resolved: pytorch#112885 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: pytorch#112836
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…state_dict (pytorch#112837) As title Differential Revision: [D50962991](https://our.internmc.facebook.com/intern/diff/D50962991/) Pull Request resolved: pytorch#112837 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: pytorch#112836, pytorch#112885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This allows us to do cpu_offload with the same traversal logic
Differential Revision: D50982355