Make pattern-matcher failure diagnostics lazy (again) and added an error message if format string is too long #112923
Conversation
…ror message if format string is too long [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112923
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9eb601b with merge base 94f3df2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
torch/_inductor/pattern_matcher.py
Outdated
| self.format_string = format_string | ||
| # We want to construct error messages lazily instead of eagerly, as | ||
| # constructing them eagerly can significantly worsen compile times. | ||
| if len(format_string) > 500: |
…added an error message if format string is too long" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ror message if format string is too long (pytorch#112923) Pull Request resolved: pytorch#112923 Approved by: https://github.com/eellison ghstack dependencies: pytorch#112476
…ror message if format string is too long (pytorch#112923) Pull Request resolved: pytorch#112923 Approved by: https://github.com/eellison ghstack dependencies: pytorch#112476
3 participants
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler