KEMBAR78
Split out input_metadata.cpp from input_metadata.h by soulitzer · Pull Request #113031 · pytorch/pytorch · GitHub
Skip to content

Conversation

@soulitzer
Copy link
Contributor

@soulitzer soulitzer commented Nov 6, 2023

@soulitzer soulitzer requested a review from albanD as a code owner November 6, 2023 16:46
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113031

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 30b93ad with merge base 1855153 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little cleanup.
If we have more of this, I would also suggest a NestedInputMetadata which would simplify some of the nested conditions you have here.

@soulitzer soulitzer added the topic: not user facing topic category label Nov 6, 2023
pytorchmergebot pushed a commit that referenced this pull request Nov 7, 2023
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
pytorchmergebot pushed a commit that referenced this pull request Nov 7, 2023
pytorchmergebot pushed a commit that referenced this pull request Nov 7, 2023
…ded_tensor msg (#113162)

Improvements: improves to_padded_tensor error message when passed a NT with zero numel

Pull Request resolved: #113162
Approved by: https://github.com/jbschlosser
ghstack dependencies: #113031, #112519, #113091
@facebook-github-bot facebook-github-bot deleted the gh/soulitzer/251/head branch November 10, 2023 15:24
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
…ded_tensor msg (pytorch#113162)

Improvements: improves to_padded_tensor error message when passed a NT with zero numel

Pull Request resolved: pytorch#113162
Approved by: https://github.com/jbschlosser
ghstack dependencies: pytorch#113031, pytorch#112519, pytorch#113091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants