KEMBAR78
Add file name and size to the serialization metadata logging by atannous · Pull Request #113077 · pytorch/pytorch · GitHub
Skip to content

Add file name and size to the serialization metadata logging #113077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add file name and size to the serialization metadata logging #113077

wants to merge 1 commit into from

Conversation

atannous
Copy link
Contributor

@atannous atannous commented Nov 6, 2023

Summary:
To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.

  • file_name
  • file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

@pytorch-bot pytorch-bot bot added the release notes: package/deploy release notes category label Nov 6, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113077

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d94ff21 with merge base e138d80 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@atannous atannous requested review from davidberard98 and suo November 7, 2023 16:51
davidberard98
davidberard98 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as tests pass

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@atannous @facebook-github-bot
Add file name and size to the serialization metadata logging (pytorch…
d94ff21 
…#113077)

Summary:

To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51040426

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 9, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@atannous @Skylion007
Add file name and size to the serialization metadata logging (pytorch…
f44d762 
…#113077)

Summary:
To be able to get more info on serialization/deserialization events, adding these two files to the metadata logging.
- file_name
- file_size

Test Plan: buck2 test mode/dev caffe2/caffe2/serialize:inline_container_test

Reviewed By: davidberard98

Differential Revision: D51040426

Pull Request resolved: pytorch#113077
Approved by: https://github.com/davidberard98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo Awaiting requested review from suo

1 more reviewer

@davidberard98 davidberard98 davidberard98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: package/deploy release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atannous @facebook-github-bot @pytorchmergebot @davidberard98