[decomp] Fix _scaled_dot_product_flash_attention decomposition bug #113102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `F.scaled_dot_product_attention` we have a positional argument: `Tensor? attn_mask=None` This is not handled correctly in `python_variables.cpp`, and it is causing issue in tracing. Fix it so that `is_default` lambda correctly returns true when the default value is None Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113102
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f7a6836 with merge base bdfde62 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
larryliu0820
added a commit
that referenced
this pull request
Nov 7, 2023
For `F.scaled_dot_product_attention` we have a positional argument: `Tensor? attn_mask=None` This is not handled correctly in `python_variables.cpp`, and it is causing issue in tracing. Fix it so that `is_default` lambda correctly returns true when the default value is None Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 5a280b4 Pull Request resolved: #113102
larryliu0820
changed the title
…tion bug" For `_scaled_dot_product_flash_attention` we don't have `Tensor? attn_mask=None` but `scaled_dot_product_attention` has. In the original decomp there's a mixup where I added this argument to `_scaled_dot_product_flash_attention`. Fix it so that `_scaled_dot_product_flash_attention` is being decomposed correctly. Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…tion bug" For `_scaled_dot_product_flash_attention` we don't have `Tensor? attn_mask=None` but `scaled_dot_product_attention` has. In the original decomp there's a mixup where I added this argument to `_scaled_dot_product_flash_attention`. Fix it so that `_scaled_dot_product_flash_attention` is being decomposed correctly. Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Nov 7, 2023
For `_scaled_dot_product_flash_attention` we don't have `Tensor? attn_mask=None` but `scaled_dot_product_attention` has. In the original decomp there's a mixup where I added this argument to `_scaled_dot_product_flash_attention`. Fix it so that `_scaled_dot_product_flash_attention` is being decomposed correctly. Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: bb643d2 Pull Request resolved: #113102
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ytorch#113102) For `_scaled_dot_product_flash_attention` we don't have `Tensor? attn_mask=None` but `scaled_dot_product_attention` has. In the original decomp there's a mixup where I added this argument to `_scaled_dot_product_flash_attention`. Fix it so that `_scaled_dot_product_flash_attention` is being decomposed correctly. Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#113102 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For
_scaled_dot_product_flash_attentionwe don't haveTensor? attn_mask=Nonebut
scaled_dot_product_attentionhas. In the original decomp there's amixup where I added this argument to
_scaled_dot_product_flash_attention.Fix it so that
_scaled_dot_product_flash_attentionis being decomposed correctly.Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: