[quant][pt2e] Add transform_for_annotation method in Quantizer #113115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Test Plan: python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113115
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9d1b047 with merge base 84d64d7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
added a commit
that referenced
this pull request
Nov 7, 2023
Summary: Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Test Plan: python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8aca038 Pull Request resolved: #113115
jerryzh168
requested review from
andrewor14,
digantdesai,
kimishpatel,
kirklandsign and
mcr229
kimishpatel
approved these changes
Nov 7, 2023
…izer" Summary: Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Test Plan: python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Nov 7, 2023
Summary: Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Test Plan: python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 602e42c Pull Request resolved: #113115
andrewor14
reviewed
Nov 7, 2023
digantdesai
reviewed
Nov 8, 2023
| # For example quantizer can | ||
| # a) decompose a compound operator like scaled dot product attention, | ||
| # into bmm and softmax if quantizer knows how to quantize bmm/softmax but not sdpa | ||
| # or b) transform scalars to tensor to allow quantizing scalares. |
There was a problem hiding this comment.
Suggested change
| # or b) transform scalars to tensor to allow quantizing scalares. | |
| # or b) transform scalars to tensor to allow quantizing scalars. |
…izer" Summary: Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Test Plan: python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…izer" Summary: Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Test Plan: python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D51141080](https://our.internmc.facebook.com/intern/diff/D51141080) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Nov 9, 2023
Summary: Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Test Plan: python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 5a7995d Pull Request resolved: #113115
|
@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jerryzh168
added a commit
to jerryzh168/executorch-1
that referenced
this pull request
Nov 9, 2023
Summary: X-link: pytorch/pytorch#113115 Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Differential Revision: D51141080
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "breaking executorch tests" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
Can't revert PR that was landed via phabricator as D51141080. Please revert by going to the internal diff and clicking Unland. |
4 tasks
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ch#113115) Summary: Adding the method so that people can do some transformations before annotation to make the graph easier to annotate Test Plan: python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D51141080](https://our.internmc.facebook.com/intern/diff/D51141080) Pull Request resolved: pytorch#113115 Approved by: https://github.com/kimishpatel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Adding the method so that people can do some transformations before annotation to make the graph easier to annotate
Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_transform_for_annotation
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D51141080