[DTensor][2/N][forward fix] extend util function normalize_to_torch_size to accept single int size #113244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize to accept single int size [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113244
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 4230f93 with merge base 56e514a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
XilunWu
added
ciflow/trunk
|
@pytorchbot merge -f "unrelated periodic CI failure - macos build" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ize to accept single int size (pytorch#113244) **Summary**: In pytorch#113105 I used the util function `normalize_to_torch_size` to unify the `size` argument that may be in multiple formats. However the use of that function would only handle input of `Sequence[int]` therefore I submit this forward fix to have `normalize_to_torch_size` also able to handle the size argument of type `int` and `torch.Size`. A side product of this fix is it also enables 3 dtensor op tests (check `test_dtensor_ops.py`). **Test**: `pytest test/distributed/_tensor/test_dtensor_ops.py` Pull Request resolved: pytorch#113244 Approved by: https://github.com/wanchaol ghstack dependencies: pytorch#113105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
In #113105 I used the util function
normalize_to_torch_sizeto unify thesizeargument that may be in multiple formats. However the use of that function would only handle input ofSequence[int]therefore I submit this forward fix to havenormalize_to_torch_sizealso able to handle the size argument of typeintandtorch.Size. A side product of this fix is it also enables 3 dtensor op tests (checktest_dtensor_ops.py).Test:
pytest test/distributed/_tensor/test_dtensor_ops.pycc @wanchaol