[funcol] a few optimizations to funcol #113324
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
LucasLLC,
awgu,
d4l3k,
fduwjj,
fegin,
kiukchung,
kwen2501,
mrshenli,
rohan-varma,
wz337 and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113324
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 2de50e9 with merge base 7843df6 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Nov 9, 2023
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops ghstack-source-id: 1d5a0cb Pull Request resolved: #113324
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops [ghstack-poisoned]
fegin
reviewed
Nov 13, 2023
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops cc H-Huang awgu kwen2501 fegin fduwjj wz337 wconstab mrshenli zhaojuanmao rohan-varma kiukchung d4l3k lucasllc XilunWu [ghstack-poisoned]
XilunWu
approved these changes
Nov 14, 2023
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops cc H-Huang awgu kwen2501 fegin fduwjj wz337 wconstab mrshenli zhaojuanmao rohan-varma kiukchung d4l3k lucasllc XilunWu [ghstack-poisoned]
fduwjj
reviewed
Nov 16, 2023
|
|
||
| @classmethod | ||
| def __torch_dispatch__(cls, func, types, args=(), kwargs=None): | ||
| if func == torch.ops.aten.view.default: |
There was a problem hiding this comment.
I am ok with perf improvement change, but would this make the code look hacky?
|
Adding |
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops cc H-Huang awgu kwen2501 fegin fduwjj wz337 wconstab mrshenli zhaojuanmao rohan-varma kiukchung d4l3k lucasllc XilunWu [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Dec 5, 2023
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops ghstack-source-id: 921e657 Pull Request resolved: #113324
wanchaol
added
the
ciflow/periodic
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops cc H-Huang awgu kwen2501 fegin fduwjj wz337 wconstab mrshenli zhaojuanmao rohan-varma kiukchung d4l3k lucasllc XilunWu tianyu-l [ghstack-poisoned]
|
Successfully rebased |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops ghstack-source-id: addcea0 Pull Request resolved: #113324
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: .github/workflows/trunk.yml / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral), .github/workflows/trunk.yml / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i "windows failures not related" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: periodic / win-vs2019-cuda11.8-py3 / build, .github/workflows/trunk.yml / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral), .github/workflows/trunk.yml / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
albanD
added
oncall: distributed
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Apply a few optimizations to funcol: - allgather on non-0 dim, the resulting tensor already needs to access data in order to do torch.cat, so we sync wait here so that we don;t need to go through ACT dispatch for chunk + cat alltogether - have a fast return logic to aten.view as it's a commonly hit op for view related ops Pull Request resolved: pytorch#113324 Approved by: https://github.com/XilunWu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Apply a few optimizations to funcol:
data in order to do torch.cat, so we sync wait here so that we don;t
need to go through ACT dispatch for chunk + cat alltogether
view related ops
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @fduwjj @wz337 @tianyu-l @wconstab @yf225 @kiukchung @LucasLLC @d4l3k