KEMBAR78
[AOTI] Delay the fallback kernel naming decision to the codegen time by desertfire · Pull Request #113660 · pytorch/pytorch · GitHub
Skip to content

[AOTI] Delay the fallback kernel naming decision to the codegen time #113660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[AOTI] Delay the fallback kernel naming decision to the codegen time #113660

wants to merge 6 commits into from

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Nov 14, 2023 •
edited
Loading

@desertfire
[AOTI] Delay the fallback kernel naming decision to the codegen time
52cb255 
Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

[ghstack-poisoned]
This was referenced Nov 14, 2023
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113660

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 93482e7 with merge base cebad98 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@desertfire
Update on "[AOTI] Delay the fallback kernel naming decision to the co…
aae4900 
…degen time"

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Nov 14, 2023
@desertfire
[AOTI] Delay the fallback kernel naming decision to the codegen time
8f01459 
Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

ghstack-source-id: b9b1aea
Pull Request resolved: #113660
@desertfire
Update on "[AOTI] Delay the fallback kernel naming decision to the co…
8402e4f 
…degen time"

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Nov 14, 2023
@desertfire
[AOTI] Delay the fallback kernel naming decision to the codegen time
94d5e31 
Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

ghstack-source-id: 566a035
Pull Request resolved: #113660
@desertfire desertfire added the topic: not user facing topic category label Nov 14, 2023
@desertfire
Update on "[AOTI] Delay the fallback kernel naming decision to the co…
d26da98 
…degen time"

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
@desertfire desertfire mentioned this pull request Nov 15, 2023
Closed
chenyang78
chenyang78 reviewed Nov 16, 2023
View reviewed changes
torch/_inductor/ir.py
x,
[x, self.constant_args[0], index, src],
self.kernel,
self.cpp_kernel if V.graph.cpp_wrapper else self.kernel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call self.codegen_kernel_name here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because codegen_kernel_name doesn't exist in the base class ExternKernel, since not all ExternKernel has a kernel name. I think @int3 raised a similar question in a different context, codegen_kwargs. I will create some other PRs to do some refactoring to the base/child classes here.

torch/_inductor/ir.py
wrapper.writeline(wrapper.wrap_kernel_call(self.kernel, args))
wrapper.writeline(
wrapper.wrap_kernel_call(
self.cpp_kernel if V.graph.cpp_wrapper else self.kernel, args
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto - can we call self.codegen_kernel_name?

torch/_inductor/ir.py
wrapper.generate_extern_kernel_alloc_and_find_schema_if_needed(
self.get_name(),
self.kernel,
self.cpp_kernel if V.graph.cpp_wrapper else self.kernel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

torch/_inductor/ir.py
self.codegen_reference(),
args,
self.kernel,
self.cpp_kernel if V.graph.cpp_wrapper else self.kernel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

chenyang78
chenyang78 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@chenyang78 chenyang78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@desertfire
Update on "[AOTI] Delay the fallback kernel naming decision to the co…
f14eb39 
…degen time"

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

Differential Revision: [D51382677](https://our.internmc.facebook.com/intern/diff/D51382677)

[ghstack-poisoned]
@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@desertfire
Update on "[AOTI] Delay the fallback kernel naming decision to the co…
93482e7 
…degen time"

Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

Differential Revision: [D51382677](https://our.internmc.facebook.com/intern/diff/D51382677)

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Nov 16, 2023
@desertfire
[AOTI] Delay the fallback kernel naming decision to the codegen time
4920bca 
Summary: This is to prepare for a later change that changes AOTI's second-pass to perform codegen only.

ghstack-source-id: bb7bce6
Pull Request resolved: #113660
@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 16, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/desertfire/265/head branch November 20, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

@jansel jansel Awaiting requested review from jansel

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@muchulee8 muchulee8 Awaiting requested review from muchulee8

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@desertfire @facebook-github-bot @pytorchmergebot @chenyang78