[ONNX][dynamo_export] Add 'aten::rsub' type promotion #113697
Conversation
[ghstack-poisoned]
BowenBao
requested review from
abock,
thiagocrepaldi and
wschin
as code owners
pytorch-bot
bot
added
the
release notes: onnx
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113697
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f7b63a8 with merge base 9146ca6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The logic is the same as 'aten::sub'. Needed by llama2. [ghstack-poisoned]
The logic is the same as 'aten::sub'. Needed by llama2. [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
The logic is the same as 'aten::sub'. Needed by llama2. [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'Sorry for reverting your change, but it is failing in trunk https://hud.pytorch.org/pytorch/pytorch/commit/48800e9bb0fd0d8aa56f961fe207b1040922fa2e. The failure on the PR is legit https://github.com/pytorch/pytorch/actions/runs/6884783862/job/18728219414, let me take a look on why Dr.CI marks it as flaky' -c weird |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@BowenBao your PR has been successfully reverted. |
This reverts commit 48800e9. Reverted #113697 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but it is failing in trunk https://hud.pytorch.org/pytorch/pytorch/commit/48800e9bb0fd0d8aa56f961fe207b1040922fa2e. The failure on the PR is legit https://github.com/pytorch/pytorch/actions/runs/6884783862/job/18728219414, let me take a look on why Dr.CI marks it as flaky ([comment](#113697 (comment)))
|
@huydhn looks like it is some float16 test with precision issue, let me retry with relaxing the constraint. |
…' type promotion" The logic is the same as 'aten::sub'. Needed by llama2. [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary - `TORCH_TO_NUMPY_DTYPE` was misplaced previously hence subclasses cannot access it. - Remove cpu fallback when benching onnx with gpu, expose gpu run failures properly. Pull Request resolved: #113703 Approved by: https://github.com/thiagocrepaldi ghstack dependencies: #113404, #113697
Recent PyTorch breaks DORT CI and [a patch](pytorch/pytorch#113697) has been merged into PyTorch main. In order to update DORT's CI, we made dummy change in this PR.
Recent PyTorch breaks DORT CI and [a patch](pytorch/pytorch#113697) has been merged into PyTorch main. In order to update DORT's CI, we made dummy change in this PR.
6 participants
Stack from ghstack (oldest at bottom):
The logic is the same as 'aten::sub'. Needed by llama2.