[dtensor] add foreach_zero_ support #113897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add foreach_zero_ op support, to fix when optim.zero_grad(set_to_none=False) hit this op and erroring out the device mesh not found issue. Also move the test to use zero_grad as the last step as that's when we going to have dtensor as grads [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113897
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b564a0a with merge base 0d6d97d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wanchaol
added
ciflow/trunk
This PR add foreach_zero_ op support, to fix when optim.zero_grad(set_to_none=False) hit this op and erroring out the device mesh not found issue. Also move the test to use zero_grad as the last step as that's when we going to have dtensor as grads cc H-Huang awgu kwen2501 fegin fduwjj wz337 wconstab mrshenli zhaojuanmao rohan-varma kiukchung d4l3k lucasllc XilunWu [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Nov 16, 2023
This PR add foreach_zero_ op support, to fix when optim.zero_grad(set_to_none=False) hit this op and erroring out the device mesh not found issue. Also move the test to use zero_grad as the last step as that's when we going to have dtensor as grads ghstack-source-id: 652f76d Pull Request resolved: #113897
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
albanD
added
oncall: distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR add foreach_zero_ op support, to fix when
optim.zero_grad(set_to_none=False) hit this op and erroring out the
device mesh not found issue.
Also move the test to use zero_grad as the last step as that's when we
going to have dtensor as grads
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @fduwjj @wz337 @tianyu-l @wconstab @yf225 @kiukchung @d4l3k @LucasLLC