[DTensor] Returned new placements for neg dim in global info #113922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113922
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 68244cc with merge base 6ed20af ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 17, 2023
[ghstack-poisoned]
This was referenced Nov 17, 2023
wanchaol
reviewed
Nov 17, 2023
awgu
pushed a commit
that referenced
this pull request
Nov 20, 2023
…ith assert in helper" This is a replacement for #113922. I think we can still leave the check for negative shard dimension in `compute_local_shape_and_global_offset` and replace the normalization logic with an assert. This should provide us a stack trace to see which user-facing API did not normalize the dim as expected. [ghstack-poisoned]
awgu
pushed a commit
that referenced
this pull request
Nov 20, 2023
…lper" This is a replacement for #113922. I think we can still leave the check for negative shard dimension in `compute_local_shape_and_global_offset` and replace the normalization logic with an assert. This should provide us a stack trace to see which user-facing API did not normalize the dim as expected. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 21, 2023
This is a replacement for #113922. I think we can still leave the check for negative shard dimension in `compute_local_shape_and_global_offset` and replace the normalization logic with an assert. This should provide us a stack trace to see which user-facing API did not normalize the dim as expected. Pull Request resolved: #114141 Approved by: https://github.com/wanchaol ghstack dependencies: #113919, #113924, #114134, #113925, #113930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
DTensorSpec#113915distribute_tensor#113930grad_placementswas tuple #113925redistribute#113924_Partial,Replicatefrozen dataclasses #113919shard_spec->placementsin test file #113917op_callin no-mesh dispatch assert message #113903_get_registryreturnNoneif no APIs applied #113654