KEMBAR78
[dtensor] enable RMSprop optimizer foreach support by wanchaol · Pull Request #114152 · pytorch/pytorch · GitHub
Skip to content

[dtensor] enable RMSprop optimizer foreach support #114152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[dtensor] enable RMSprop optimizer foreach support #114152

wants to merge 2 commits into from

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Nov 20, 2023 •
edited by pytorch-bot bot
Loading

This was referenced Nov 20, 2023
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114152

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3ca5917 with merge base edc5ae3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wanchaol wanchaol mentioned this pull request Nov 20, 2023
Closed
@wanchaol wanchaol requested a review from awgu November 20, 2023 20:46
XilunWu
XilunWu approved these changes Nov 20, 2023
View reviewed changes
@wanchaol
Update on "[dtensor] enable RMSprop optimizer foreach support"
3ca5917 
as titled

cc H-Huang awgu kwen2501 fegin fduwjj wz337 wconstab mrshenli zhaojuanmao rohan-varma kiukchung d4l3k lucasllc XilunWu

[ghstack-poisoned]
wanchaol added a commit that referenced this pull request Nov 20, 2023
@wanchaol
[dtensor] enable RMSprop optimizer foreach support
c0033b8 
as titled

ghstack-source-id: 29346de
Pull Request resolved: #114152
@wanchaol wanchaol added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2023
@wanchaol
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@wanchaol
Copy link
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@wanchaol
Copy link
Collaborator Author

@pytorchbot merge -f "failure not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/397/head branch November 24, 2023 15:28
@albanD albanD added oncall: distributed Add this issue/PR to distributed oncall triage queue and removed module: distributed labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XilunWu XilunWu XilunWu approved these changes

@awgu awgu Awaiting requested review from awgu

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (dtensor) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wanchaol @pytorchmergebot @XilunWu @albanD