KEMBAR78
ci: Clean up logic for `merge -r` by seemethere · Pull Request #114295 · pytorch/pytorch · GitHub
Skip to content

ci: Clean up logic for merge -r #114295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ci: Clean up logic for merge -r #114295

wants to merge 2 commits into from

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Nov 21, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Rely on built in bash conditionals for doing the if statement rather
than relying on $?

To avoid issues observed in #111008 (comment)

Signed-off-by: Eli Uriegas eliuriegas@meta.com

@seemethere
ci: Clean up logic for merge -r
2992ad1 
Rely on built in bash conditionals for doing the if statement rather
than relying on $?

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114295

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c5cef68 with merge base d1ae5ef (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 21, 2023
@seemethere seemethere requested review from a team and clee2000 November 21, 2023 19:39
@kit1980 kit1980 requested a review from malfet November 21, 2023 19:42
huydhn
huydhn approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seemethere
Copy link
Member Author

I also don't know if there's a good way to test this without a YOLO

@seemethere
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

malfet
malfet approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also add shell: bash to avoid any unexpected changes

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@seemethere
Update on "ci: Clean up logic for merge -r"
c5cef68 
Rely on built in bash conditionals for doing the if statement rather
than relying on $?

To avoid issues observed in #111008 (comment)

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Nov 21, 2023
@seemethere
ci: Clean up logic for merge -r
fbabce4 
Rely on built in bash conditionals for doing the if statement rather
than relying on $?

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 7ba8d9b
Pull Request resolved: #114295

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/seemethere/251/head branch November 25, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

@clee2000 clee2000 Awaiting requested review from clee2000

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seemethere @pytorchmergebot @huydhn @malfet