[Quant] Enable QConv2d with hardtanh post op #114578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
leslie-fang-intel
requested review from
digantdesai,
jerryzh168,
jianyuh,
kimishpatel and
salilsdesai
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114578
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 83aadde with merge base 11f11e9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
module: cpu
This was referenced Nov 27, 2023
Closed
leslie-fang-intel
changed the title
jgong5
approved these changes
Nov 27, 2023
**Summary** Enable QConv2d implementation with post op `hardtanh` **Test Plan** ``` python -m pytest test_quantized_op.py -k test_qconv2d_hardtanh_pt2e ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
to leslie-fang-intel/pytorch
that referenced
this pull request
Nov 27, 2023
ghstack-source-id: fb1c31d Pull Request resolved: pytorch#114578
jerryzh168
approved these changes
Nov 28, 2023
**Summary** Enable QConv2d implementation with post op `hardtanh` **Test Plan** ``` python -m pytest test_quantized_op.py -k test_qconv2d_hardtanh_pt2e ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
to leslie-fang-intel/pytorch
that referenced
this pull request
Nov 28, 2023
ghstack-source-id: f3f8eb4 Pull Request resolved: pytorch#114578
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 28, 2023
… Unary Annotation (#114579) **Summary** Add `Hardtanh` and `ReLU6` into X86InductorQuantizer Conv2d Unary Annotation **TestPlan** ``` python -m pytest test_x86inductor_quantizer.py -k test_conv2d_unary python -m pytest test_x86inductor_quantizer.py -k test_qat_conv2d_unary ``` Pull Request resolved: #114579 Approved by: https://github.com/jgong5, https://github.com/jerryzh168 ghstack dependencies: #114578
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 28, 2023
…rdtanh (#114580) **Summary** Enable the fusion pattern of `QConv2d -> hardtanh` lowering to `hardtanh` as `QConv2d` post operator. **Test Plan** ``` python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_relu6_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qconv2d_hardtanh_cpu python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_relu6 python -m pytest test_mkldnn_pattern_matcher.py -k test_qat_qconv2d_hardtanh ``` Pull Request resolved: #114580 Approved by: https://github.com/jgong5, https://github.com/jerryzh168 ghstack dependencies: #114578, #114579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Enable QConv2d implementation with post op
hardtanhTest Plan
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10