KEMBAR78
Inductor cpp wrapper: fix buffer free in non-AOT mode by chunyuan-w · Pull Request #114741 · pytorch/pytorch · GitHub
Skip to content

Inductor cpp wrapper: fix buffer free in non-AOT mode #114741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Inductor cpp wrapper: fix buffer free in non-AOT mode #114741

wants to merge 4 commits into from

Conversation

@chunyuan-w
Copy link
Collaborator

@chunyuan-w chunyuan-w commented Nov 29, 2023 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

We found performance regression when using cpp wrapper in non-AOT mode due to the change in #110892.
#110892 only handles the buffer cache in AOT mode but removes the reset call without checking whether AOT mode is on or off. This PR updates the buffer free change to only happen when V.graph.aot_mode is True.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114741

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 22c23ab with merge base 0ced55e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

chunyuan-w added a commit that referenced this pull request Nov 29, 2023
@chunyuan-w
Inductor cpp wrapper: fix buffer free in non-AOT mode
c3fccb9 
ghstack-source-id: 326e66b
Pull Request resolved: #114741
@chunyuan-w chunyuan-w requested a review from jgong5 November 29, 2023 14:07
@chunyuan-w
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@chunyuan-w
Update on "Inductor cpp wrapper: fix buffer free in non-AOT mode"
6448e39 
We found performance regression when using cpp wrapper in non-AOT mode due to the change in #110892.
#110892 only handles the buffer cache in AOT mode but removes the `reset` call without checking whether AOT mode is on or off. This PR updates the buffer free change to only happen when `V.graph.aot_mode is True`.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/chunyuan-w/1/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/114741)

desertfire
desertfire reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@desertfire desertfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add a test that counts the reset() statements.

@chunyuan-w
Update on "Inductor cpp wrapper: fix buffer free in non-AOT mode"
a307dcb 
We found performance regression when using cpp wrapper in non-AOT mode due to the change in #110892.
#110892 only handles the buffer cache in AOT mode but removes the `reset` call without checking whether AOT mode is on or off. This PR updates the buffer free change to only happen when `V.graph.aot_mode is True`.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
@chunyuan-w
Update on "Inductor cpp wrapper: fix buffer free in non-AOT mode"
22c23ab 
We found performance regression when using cpp wrapper in non-AOT mode due to the change in #110892.
#110892 only handles the buffer cache in AOT mode but removes the `reset` call without checking whether AOT mode is on or off. This PR updates the buffer free change to only happen when `V.graph.aot_mode is True`.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Nov 30, 2023
@chunyuan-w
Inductor cpp wrapper: fix buffer free in non-AOT mode
d045813 
ghstack-source-id: f2934a5
Pull Request resolved: #114741
@chunyuan-w
Copy link
Collaborator Author

Better to add a test that counts the reset() statements.

Test has been added.

@chunyuan-w
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 30, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@chunyuan-w chunyuan-w added the topic: not user facing topic category label Nov 30, 2023
@chunyuan-w
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@chunyuan-w chunyuan-w mentioned this pull request Dec 1, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/chunyuan-w/1/head branch December 4, 2023 15:29
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@chunyuan-w @dmenig
Inductor cpp wrapper: fix buffer free in non-AOT mode (pytorch#114741)
0e486dc 
We found performance regression when using cpp wrapper in non-AOT mode due to the change in pytorch#110892.
pytorch#110892 only handles the buffer cache in AOT mode but removes the `reset` call without checking whether AOT mode is on or off. This PR updates the buffer free change to only happen when `V.graph.aot_mode is True`.

Pull Request resolved: pytorch#114741
Approved by: https://github.com/jgong5, https://github.com/desertfire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire desertfire approved these changes

@jgong5 jgong5 jgong5 approved these changes

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chunyuan-w @pytorchmergebot @desertfire @jgong5 @pytorchbot