KEMBAR78
[tgif] allow preserving non-forward methods during deepcopy by 842974287 · Pull Request #114849 · pytorch/pytorch · GitHub
Skip to content

[tgif] allow preserving non-forward methods during deepcopy #114849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[tgif] allow preserving non-forward methods during deepcopy #114849

wants to merge 1 commit into from

Conversation

@842974287
Copy link
Contributor

Summary:
bypass-github-export-checks
force-merge-on-github

Reviewed By: sayitmemory

Differential Revision: D51629520

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 30, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 30, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114849

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e947537 with merge base 7b3e45b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51629520

@842974287 842974287 mentioned this pull request Nov 30, 2023
Closed
842974287 added a commit to 842974287/vision that referenced this pull request Nov 30, 2023
@842974287 @facebook-github-bot
[tgif] allow preserving non-forward methods during deepcopy
f62ecdf 
Summary:
X-link: pytorch/pytorch#114849

bypass-github-export-checks
force-merge-on-github

Reviewed By: sayitmemory

Differential Revision: D51629520
@842974287 @facebook-github-bot
[tgif] allow preserving non-forward methods during deepcopy (pytorch#…
e947537 
…114849)

Summary:
X-link: pytorch/vision#8135


bypass-github-export-checks
force-merge-on-github

Differential Revision: D51629520
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51629520

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51629520

houseroad
houseroad approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@842974287 @dmenig
[tgif] allow preserving non-forward methods during deepcopy (pytorch#…
50ca269 
…114849)

Summary:
bypass-github-export-checks
force-merge-on-github

Reviewed By: sayitmemory

Differential Revision: D51629520

Pull Request resolved: pytorch#114849
Approved by: https://github.com/houseroad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

@zyan0 zyan0 Awaiting requested review from zyan0

@Chillee Chillee Awaiting requested review from Chillee

Assignees

No one assigned

Labels

fb-exported Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@842974287 @facebook-github-bot @pytorchmergebot @houseroad