KEMBAR78
Reland #113487 and #112527 (sdpa shim & fp8 AOTInductor support) by int3 · Pull Request #114974 · pytorch/pytorch · GitHub
Skip to content

Reland #113487 and #112527 (sdpa shim & fp8 AOTInductor support) #114974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Reland #113487 and #112527 (sdpa shim & fp8 AOTInductor support) #114974

wants to merge 2 commits into from

Conversation

@int3
Copy link
Contributor

@int3 int3 commented Dec 1, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

This is a backout of #113747 which reverted the above two commits. Now that
#113997 has landed, this diff can be landed safely without breaking ABI compatibility.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler

@int3
Reland #113487 and #112527 (sdpa shim & fp8 AOTInductor support)
0f9b7d5 
This is a backout of #113747 which reverted the above two commits.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114974

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 86a3256 with merge base ec124b9 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

int3 added a commit that referenced this pull request Dec 1, 2023
@int3
Reland #113487 and #112527 (sdpa shim & fp8 AOTInductor support)
3f648d4 
This is a backout of #113747 which reverted the above two commits.

ghstack-source-id: f5a794f
Pull Request resolved: #114974
@int3 int3 requested a review from chenyang78 December 1, 2023 19:19
@int3
Copy link
Contributor Author

int3 commented Dec 1, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 1, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@int3
Copy link
Contributor Author

int3 commented Dec 1, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@chenyang78
Copy link
Contributor

@int3 Looks like there is some linter failure.

@int3
Copy link
Contributor Author

int3 commented Dec 2, 2023

oh right I fixed it locally but I guess I forgot to update the PR

@int3
Update on "Reland #113487 and #112527 (sdpa shim & fp8 AOTInductor su…
86a3256 
…pport)"


This is a backout of #113747 which reverted the above two commits. Now that
#113997 has landed, this diff can be landed safely without breaking ABI compatibility.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
int3 added a commit that referenced this pull request Dec 2, 2023
@int3
Reland #113487 and #112527 (sdpa shim & fp8 AOTInductor support)
df262d3 
This is a backout of #113747 which reverted the above two commits.

Pull Request resolved: #114974
ghstack-source-id: fecfab4
@int3
Copy link
Contributor Author

int3 commented Dec 2, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/int3/103/head branch December 5, 2023 15:28
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@int3 @dmenig
Reland pytorch#113487 and pytorch#112527 (sdpa shim & fp8 AOTInductor…
4f1701a 
… support) (pytorch#114974)

This is a backout of pytorch#113747 which reverted the above two commits. Now that
pytorch#113997 has landed, this diff can be landed safely without breaking ABI compatibility.

Pull Request resolved: pytorch#114974
Approved by: https://github.com/chenyang78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@int3 @pytorchmergebot @chenyang78