[dynamo] support dict.update(seq2) / OrderedDict.update(seq2) / defaultdict.update(seq2)
#115011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defaultdict.update(seq2)` [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115011
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 11c7b02 with merge base ec124b9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 2, 2023
…(seq2)` / `defaultdict.update(seq2)`" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…(seq2)` / `defaultdict.update(seq2)`" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Dec 2, 2023
…defaultdict.update(seq2)` ghstack-source-id: c32d63e Pull Request resolved: pytorch#115011
…(seq2)` / `defaultdict.update(seq2)`" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
XuehaiPan
commented
Dec 3, 2023
| dd["c"] = x * 2 | ||
| dd.update({"b": x * 3}) | ||
| dd.update([["d", x - 2], ("e", x + 2)]) | ||
| dd.update(zip("ab", [x + 3, x + 4])) |
There was a problem hiding this comment.
The test for defaultdict.update is not placed in a separate @make_test function. Because the collections module is ignored in SKIP_DIRS.
…(seq2)` / `defaultdict.update(seq2)`" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…(seq2)` / `defaultdict.update(seq2)`" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Dec 3, 2023
…defaultdict.update(seq2)` ghstack-source-id: 65cdd6d Pull Request resolved: pytorch#115011
jansel
approved these changes
Dec 4, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 4, 2023
…copy()` (#115012) Pull Request resolved: #115012 Approved by: https://github.com/jansel ghstack dependencies: #115010, #115011
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…defaultdict.update(seq2)` (pytorch#115011) Pull Request resolved: pytorch#115011 Approved by: https://github.com/jansel ghstack dependencies: pytorch#115010
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…copy()` (pytorch#115012) Pull Request resolved: pytorch#115012 Approved by: https://github.com/jansel ghstack dependencies: pytorch#115010, pytorch#115011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
dictin sorted key ordering #114947dict.copy()/OrderedDict.copy()/defaultdict.copy()#115012dict.update(seq2)/OrderedDict.update(seq2)/defaultdict.update(seq2)#115011dict.fromkeys()/OrderedDict.fromkeys()/defaultdict.fromkeys()#115010cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng