[inductor] Replace rand[n].generator with inductor prim if generator=None #115051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…None This fixes the "should have been handled in replace_random.py" error raised during lowering. I also fixed `test_randn_generator` to catch any regressions. Previously, it did not use the result of randn(), so dynamo tracing omitted that node entirely. Fixes #114203. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115051
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9ccecc5 with merge base a70c85c ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
… generator=None" This fixes the "should have been handled in replace_random.py" error raised during lowering. I also fixed `test_randn_generator` to catch any regressions. Previously, it did not use the result of randn(), so dynamo tracing omitted that node entirely. Fixes #114203. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
… generator=None" This fixes the "should have been handled in replace_random.py" error raised during lowering. I also fixed `test_randn_generator` to catch any regressions. Previously, it did not use the result of randn(), so dynamo tracing omitted that node entirely. Fixes #114203. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Dec 4, 2023
…None This fixes the "should have been handled in replace_random.py" error raised during lowering. I also fixed `test_randn_generator` to catch any regressions. Previously, it did not use the result of randn(), so dynamo tracing omitted that node entirely. Fixes #114203. ghstack-source-id: 8a0f5f5 Pull Request resolved: #115051
… generator=None" This fixes the "should have been handled in replace_random.py" error raised during lowering. I also fixed `test_randn_generator` to catch any regressions. Previously, it did not use the result of randn(), so dynamo tracing omitted that node entirely. Fixes #114203. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
eellison
approved these changes
Dec 4, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
… generator=None" This fixes the "should have been handled in replace_random.py" error raised during lowering. I also fixed `test_randn_generator` to catch any regressions. Previously, it did not use the result of randn(), so dynamo tracing omitted that node entirely. Fixes #114203. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Dec 4, 2023
…None This fixes the "should have been handled in replace_random.py" error raised during lowering. I also fixed `test_randn_generator` to catch any regressions. Previously, it did not use the result of randn(), so dynamo tracing omitted that node entirely. Fixes #114203. ghstack-source-id: e184cb5 Pull Request resolved: #115051
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…None (pytorch#115051) This fixes the "should have been handled in replace_random.py" error raised during lowering. I also fixed `test_randn_generator` to catch any regressions. Previously, it did not use the result of randn(), so dynamo tracing omitted that node entirely. Fixes pytorch#114203. Pull Request resolved: pytorch#115051 Approved by: https://github.com/eellison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This fixes the "should have been handled in replace_random.py" error
raised during lowering.
I also fixed
test_randn_generatorto catch any regressions.Previously, it did not use the result of randn(), so dynamo tracing
omitted that node entirely.
Fixes #114203.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler