Generate exhaustive compiled optimizer tests #115906
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115906
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit ffa4892 with merge base 194d57d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mlazos
added
release notes: dynamo
release notes: inductor
ciflow/trunk
janeyx99
reviewed
Dec 15, 2023
janeyx99
reviewed
Dec 15, 2023
janeyx99
reviewed
Dec 15, 2023
janeyx99
reviewed
Dec 15, 2023
janeyx99
approved these changes
Dec 15, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
Generates tests for all permutations of arguments using the existing optimizer infos. Covers capturable, cpu/gpu, single/multitensor and optimizer specific constants like rho/etas, etc. [new test list](https://gist.github.com/mlazos/d3404383e7c3d490cbb51b7d6c750629) [old test list](https://gist.github.com/mlazos/e0043aee1b6a0962d2f3ac8193aa62f8) Pull Request resolved: pytorch#115906 Approved by: https://github.com/janeyx99
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
Generates tests for all permutations of arguments using the existing optimizer infos. Covers capturable, cpu/gpu, single/multitensor and optimizer specific constants like rho/etas, etc. [new test list](https://gist.github.com/mlazos/d3404383e7c3d490cbb51b7d6c750629) [old test list](https://gist.github.com/mlazos/e0043aee1b6a0962d2f3ac8193aa62f8) Pull Request resolved: pytorch#115906 Approved by: https://github.com/janeyx99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates tests for all permutations of arguments using the existing optimizer infos.
Covers capturable, cpu/gpu, single/multitensor and optimizer specific constants like rho/etas, etc.
new test list
old test list
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler