[DCP][state_dict][doc] Update the distributed state_dict document #121290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title [ghstack-poisoned]
This was referenced Mar 6, 2024
Closed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121290
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ade614a with merge base 34a28f0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
As title cc LucasLLC [ghstack-poisoned]
LucasLLC
approved these changes
Mar 6, 2024
|
|
||
| To tackle these challenges, we offer a collection of APIs for users to easily manage state_dicts. `get_model_state_dict` returns a model state dictionary with keys consistent with those returned by the unparallelized model state dictionary. Similarly, `get_optimizer_state_dict` provides the optimizer state dictionary with keys uniform across all parallelisms applied. To achieve this consistency, `get_optimizer_state_dict` converts parameter IDs to fully qualified names identical to those found in the unparallelized model state dictionary. | ||
|
|
||
| Note that results returned by hese APIs can be used directly with the `save()` and `load()` methods without requiring any additional conversions. |
There was a problem hiding this comment.
Should we clarify here that this is distributed.checkpoint.save/load vs torch?
fegin
changed the title
…ocument" As title cc LucasLLC [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 12, 2024
Root may not exist due to FSDP lazy initialization. Pull Request resolved: #121544 Approved by: https://github.com/Skylion007 ghstack dependencies: #121273, #121276, #121290
mvpatel2000
pushed a commit
to mvpatel2000/pytorch
that referenced
this pull request
May 17, 2024
Root may not exist due to FSDP lazy initialization. Pull Request resolved: pytorch#121544 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#121273, pytorch#121276, pytorch#121290
atalman
pushed a commit
that referenced
this pull request
May 27, 2024
Root may not exist due to FSDP lazy initialization. Pull Request resolved: #121544 Approved by: https://github.com/Skylion007 ghstack dependencies: #121273, #121276, #121290 Co-authored-by: Chien-Chin Huang <chienchin@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As title
cc @LucasLLC