Don't plumb shape_env per tensor conversion. #121855

ezyang · 2024-03-13T21:55:01Z

Stack from ghstack (oldest at bottom):

-> Don't plumb shape_env per tensor conversion. #121855

The only reason we did this was when static_shapes is True,
we would nub out the shape_env, but we can do this better with
a policy instead.

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-03-13T21:55:04Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121855

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures, 34 Unrelated Failures

As of commit bf13d68 with merge base failed to retrieve merge base, please contact dev infra ():

NEW FAILURES - The following jobs have failed:

inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
convit_base
inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
xcit_large_24_p8_224
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper_abi_compatible, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_cuda_cpp_wrapper.py::DynamicShapesCudaWrapperCudaTests::test_scaled_dot_product_attention_cuda_dynamic_shapes_cuda_wrapper
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
detectron2_fcos_r_50_fpn
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
vision_maskrcnn
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (cpu_inductor_torchbench, 1, 2, linux.12xlarge) (gh)
detectron2_maskrcnn_r_50_fpn
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_timm, 1, 2, linux.12xlarge) (gh)
mixer_b16_224
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_timm, 2, 2, linux.12xlarge) (gh)
xcit_large_24_p8_224
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.12xlarge) (gh)
yolov3
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (inductor_torchbench_cpu_smoketest_perf, 1, 1, linux.12xlarge) (gh)
Process completed with exit code 255.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (aot_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
detectron2_fcos_r_50_fpn
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (aot_eager_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
vision_maskrcnn
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
detectron2_fcos_r_50_fpn
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
vision_maskrcnn
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, linux.4xlarge.nvidia.gpu) (gh)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh)
test_proxy_tensor.py::TestSymbolicTracing::test_broadcast_shapes
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_aot_inductor.py::AOTInductorTestABICompatibleCpu::test_cond_nested_abi_compatible_cpu
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 4, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_aot_inductor.py::AOTInductorTestABICompatibleCpu::test_cond_with_outer_code_before_after_abi_compatible_cpu
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_aot_inductor.py::AOTInductorTestABICompatibleCpu::test_cond_simple_abi_compatible_cpu
pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh)
test_proxy_tensor.py::TestSymbolicTracing::test_broadcast_shapes
pull / linux-focal-py3.11-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
test_python_dispatch.py::TestPythonRegistration::test_returning_symint
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
test_proxy_tensor.py::TestSymbolicTracing::test_broadcast_shapes
pull / linux-focal-py3.12-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
test_proxy_tensor.py::TestSymbolicTracing::test_broadcast_shapes
pull / linux-focal-py3.12-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
functorch/test_aotdispatch.py::TestAOTModuleSimplified::test_aot_module_simplified_dynamic
pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh)
test_proxy_tensor.py::TestSymbolicTracing::test_broadcast_shapes
pull / linux-focal-py3.8-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-focal-py3.8-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
export/test_serialize.py::TestDeserialize::test_dynamic
pull / linux-focal-py3.8-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
test_proxy_tensor.py::TestSymbolicTracing::test_broadcast_shapes
pull / linux-jammy-py3.10-clang15-asan / test (default, 4, 6, linux.4xlarge) (gh)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-jammy-py3.8-gcc11 / test (default, 2, 3, linux.2xlarge) (gh)
dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error
pull / linux-jammy-py3.8-gcc11 / test (default, 3, 3, linux.2xlarge) (gh)
export/test_serialize.py::TestDeserialize::test_dynamic

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
hf_T5
inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
tts_angular
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu) (gh)
test/distributed/_tensor/test_dtensor_compile.py::TestDTensorCompileE2E::test_tp_compile_fullgraph_is_seq_parallel_True_use_native_funcol_True
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_torchinductor.py::GPUTests::test_inductor_assert_cuda
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 1, 2, linux.12xlarge) (gh)
hf_distil_whisper
inductor / rocm6.0-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2) (gh)
inductor/test_torchinductor.py::GPUTests::test_inductor_assert_cuda
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
convit_base
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
xcit_large_24_p8_224
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
hf_T5
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
tts_angular
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu) (gh)
distributed/_tensor/test_dtensor_compile.py::TestDTensorCompile::test_dtensor_attribute_access_on_intermediate_use_native_funcol_False
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, linux.8xlarge.nvidia.gpu) (gh)
distributed/test_dynamo_distributed.py::TestSingleProc::test_async_subclass_no_specialize
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 1, 5, linux.4xlarge.nvidia.gpu) (gh)
inductor/test_distributed_patterns.py::DistributedPatternTests::test_module_backward_hooks_eager
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh)
inductor/test_torchinductor_codegen_dynamic_shapes.py::DynamicShapesCodegenCpuTests::test_abs_dynamic_shapes_cpu
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 4, 5, linux.4xlarge.nvidia.gpu) (gh)
export/test_serialize.py::TestDeserialize::test_dynamic
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_torchinductor_codegen_dynamic_shapes.py::DynamicShapesCodegenCpuTests::test_adaptive_avg_pool2d1_dynamic_shapes_cpu
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_distributed_patterns.py::DistributedPatternTests::test_module_backward_hooks_eager
pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, linux.2xlarge) (gh)
export/test_serialize.py::TestDeserialize::test_dynamic
pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
inductor/test_distributed_patterns.py::DistributedPatternTests::test_module_backward_hooks_eager
pull / linux-focal-py3.11-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
export/test_serialize.py::TestDeserialize::test_dynamic
pull / linux-focal-py3.11-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
test_fake_tensor.py::FakeTensorTest::test_jagged_fake_to_fake_preserved
pull / linux-focal-py3.12-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
test_fake_tensor.py::FakeTensorTest::test_jagged_fake_to_fake_preserved
pull / linux-focal-py3.8-clang10 / test (crossref, 2, 2, linux.2xlarge) (gh)
export/test_serialize.py::TestDeserialize::test_dynamic
pull / linux-focal-py3.8-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
inductor/test_distributed_patterns.py::DistributedPatternTests::test_module_backward_hooks_eager
pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
test_fake_tensor.py::FakeTensorTest::test_jagged_fake_to_fake_preserved
pull / linux-focal-py3.8-clang10-onnx / test (default, 1, 2, linux.2xlarge) (gh)
onnx/torch_export/test_torch_export_with_onnxruntime.py::TestFxToOnnxWithOnnxRuntime::test_exported_program_as_input_lifting_buffers_mutation
pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge) (gh)
onnx/dynamo/test_dynamo_with_onnxruntime_backend.py::TestDynamoWithONNXRuntime::test_elementwise_function_multiple_output_0
pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, linux.4xlarge) (gh)
inductor/test_distributed_patterns.py::DistributedPatternTests::test_module_backward_hooks_eager
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, linux.4xlarge) (gh)
inductor/test_torchinductor_codegen_dynamic_shapes.py::DynamicShapesCodegenCpuTests::test_adaptive_avg_pool2d1_dynamic_shapes_cpu
pull / linux-jammy-py3.10-clang15-asan / test (default, 3, 6, linux.4xlarge) (gh)
functorch/test_aotdispatch.py::TestPartitioning::test_default_partitioner_output_tensor_shape_tensor
pull / linux-jammy-py3.10-clang15-asan / test (default, 5, 6, linux.4xlarge) (gh)
export/test_serialize.py::TestDeserialize::test_dynamic
pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, linux.4xlarge) (gh)
inductor/test_cpu_cpp_wrapper.py::TestCppWrapper::test_qconv2d_maxpool2d_linear_dynamic_cpu_cpp_wrapper
pull / linux-jammy-py3.8-gcc11 / test (default, 1, 3, linux.2xlarge) (gh)
inductor/test_distributed_patterns.py::DistributedPatternTests::test_module_backward_hooks_eager
pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, linux.2xlarge) (gh)
distributed/_tensor/test_dtensor_compile.py::TestDTensorCompile::test_dtensor_attribute_access_on_intermediate_use_native_funcol_False

This comment was automatically generated by Dr. CI and updates every 15 minutes.

The only reason we did this was when static_shapes is True, we would nub out the shape_env, but we can do this better with a policy instead. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: e536724 Pull Request resolved: #121855

[ghstack-poisoned]

The only reason we did this was when static_shapes is True, we would nub out the shape_env, but we can do this better with a policy instead. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: ff82da1 Pull Request resolved: #121855

[ghstack-poisoned]

The only reason we did this was when static_shapes is True, we would nub out the shape_env, but we can do this better with a policy instead. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: b2c563a Pull Request resolved: #121855

ezyang · 2024-03-19T04:17:53Z

i'll try again after the other refactors land. what a mess

Update

a67cd8f

[ghstack-poisoned]

pytorch-bot bot added the ciflow/inductor label Mar 13, 2024

github-actions bot requested review from SherlockNoMad, albanD, antoniojkim, bdhirsh and miladm March 13, 2024 21:55

albanD removed their request for review March 14, 2024 18:21

Update

5335287

[ghstack-poisoned]

Update

8de54f1

[ghstack-poisoned]

Update

bf13d68

[ghstack-poisoned]

pytorch-bot bot added module: dynamo release notes: fx release notes category labels Mar 16, 2024

ezyang closed this Mar 19, 2024

ezyang mentioned this pull request Apr 9, 2024

Fakeifying views shouldnt create symbols when dynamic=False #123348

Closed

github-actions bot deleted the gh/ezyang/2610/head branch April 19, 2024 01:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Don't plumb shape_env per tensor conversion. #121855

Don't plumb shape_env per tensor conversion. #121855

Uh oh!

ezyang commented Mar 13, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Mar 13, 2024 •

edited

Loading

Uh oh!

ezyang commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Don't plumb shape_env per tensor conversion. #121855

Don't plumb shape_env per tensor conversion. #121855

Uh oh!

Conversation

ezyang commented Mar 13, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121855

❌ 32 New Failures, 34 Unrelated Failures

Uh oh!

ezyang commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ezyang commented Mar 13, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 13, 2024 •

edited

Loading