KEMBAR78
Delete torch.autograd.function.traceable APIs by zou3519 · Pull Request #122817 · pytorch/pytorch · GitHub
Skip to content

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Mar 27, 2024

Stack from ghstack (oldest at bottom):

We deprecated them in 2.3 with plans to delete in 2.4. Very few OSS
repos use this flag at all and it also does nothing.

We deprecated them in 2.3 with plans to delete in 2.4. Very few OSS
repos use this flag at all and it also does nothing.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122817

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 464ab70 with merge base eb5381d (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zou3519 added a commit that referenced this pull request Mar 27, 2024
We deprecated them in 2.3 with plans to delete in 2.4. Very few OSS
repos use this flag at all and it also does nothing.

ghstack-source-id: 78a3d88
Pull Request resolved: #122817
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cleanup 🎉

@albanD albanD added release notes: autograd release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc_breaking labels Mar 27, 2024
@zou3519 zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 28, 2024
@zou3519
Copy link
Contributor Author

zou3519 commented Mar 28, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
We deprecated them in 2.3 with plans to delete in 2.4. Very few OSS
repos use this flag at all and it also does nothing.
Pull Request resolved: pytorch#122817
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the gh/zou3519/938/head branch April 28, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: autograd release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants